https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Turns out you can type, you just can't see what you are typing. It is the indicator class in the css that is causing it. For some reason it now doesn't like 1em as a width, it is too small. (At least in firefox) It seems to work ok in chrome -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lowering the severity a bit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- It is caused by different box-sizing in bootstrap 3 (border-box) We have to options: 1) remove width: 1em styling for indicators - the width calculation will fallback to size parameter of input tag 2) or change the box-sizing to content-box for indicators a have no strong opinion on this, probably would go with 2) as it looks more similar to pre-16239 ages ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #7 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59177&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59195|0 |1 is obsolete| | --- Comment #10 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59196&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. I have made a patch for 2em and 3em and this is the 3em one because the 2em is still too small on my screen. Choose which one works better for you -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59195|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 59356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59356&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. I have made a patch for 2em and 3em and this is the 3em one because the 2em is still too small on my screen. Choose which one works better for you Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please see comment 6 for a better solution. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the trick might be to add content-box without removing indicator. And just remove the styling applied to indicator from the CSS file. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59355|0 |1 is obsolete| | Attachment #59356|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59487&action=edit Bug 17929 - You can't edit indicators in the cataloging screen Test plan: 0. Do not apply the patch 1. Edit a biblio record, note you can't edit an indicator (in fact you edit it, but can't see the value) 2. Edit an authority record, note you can't edit an indicator (in fact you edit it, but can't see the value) 3. Apply the patch, you may need clear the browser cache (in Firefox Ctrl+F5 is often enough) 4. Repeat steps 1 and 2 - but now you will be able to edit the indicator -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Seems a shame to take a patch off a high school student. But OK -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org Status|Needs Signoff |Signed Off --- Comment #21 from J Schmidt <jschmidt@switchinc.org> --- Worked in sandbox ByWater on 1/26/17 (Chrome): Steps taken: 1.) Searched in the staff client to locate a biblio record. 2.) Clicked on Edit record (to edit biblio) 3.) Defaults to the basic editor. 4.) I click on indicators next to several MARC fields (243, 250, 710), I was able to edit and delete both the first and/or second indicators and successfully save without error. I was able to see the edits/changes. 5.) Went back into edit biblio screen. Still in basic editing mode. I went into 245 field and noticed subfields can click on. I choose 245$h and changed that to a comma and was able to save it. This means there is no validation on retaining correct subfields but perhaps that can be set in the framework itself. 6.) Clicking on the ? next to a MARC field correctly takes user to the MARC 21 format web page. (Works as should). 7.) Went to 100 field, entered in subfield a and then clicked on the icon to perform authority search to locate a personal name authority to link to subfield 9. Successfully got authority search dialog box to open up and perform searches. 8.) Located a personal name authority Campbell-Smith, Duncan. Chose it. 9.) 100$9 now populated with the authority record number and correct $a personal name. Saved without error. 10.) Went into Koha admin > Labs, changed the preference to enable the advanced cataloging editor. Save. 11.) Went back into Edit biblio. Changed to Advanced editor. 12.) Went into MARC 500 to edit indicators. I could edit and see numbers. Success. I had to tread carefully not to overwrite the field data itself. Upon save the advanced editor validates and tells you which tags are mandatory... Much improved. 13.) I put in bad indicators for the 300 field and it gave me invalid. Good. I had to do underline for blank which was not intuitive but me typing those in manually worked and the editor was able to detect error of incorrect indicator so far as I could tell. 14.) 003 is not familiar to me so I entered in DDC and Record saved successfully. 15.) Went to 650 to try and add in CTRL+D 9 for authority record number...but no way to access authority search dialog box from this screen. I would say this is working well. The advanced editor still needs to allow macros that stick overtime and are tied to login so as not to lose them. Keyboard shortcuts or macros needed for fixed fields such as 007, 008, 006 especially. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59487|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59620&action=edit Bug 17929 - You can't edit indicators in the cataloging screen Test plan: 0. Do not apply the patch 1. Edit a biblio record, note you can't edit an indicator (in fact you edit it, but can't see the value) 2. Edit an authority record, note you can't edit an indicator (in fact you edit it, but can't see the value) 3. Apply the patch, you may need clear the browser cache (in Firefox Ctrl+F5 is often enough) 4. Repeat steps 1 and 2 - but now you will be able to edit the indicator Signed-off-by: J Schmidt <jschmidt@switchinc.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 16239 is not in 16.11.x - patch is not needed there. -- You are receiving this mail because: You are watching all bug changes.