[Bug 32501] New: Koha::Patrons::Import contains incorrect borrowernumber references
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32501 Bug ID: 32501 Summary: Koha::Patrons::Import contains incorrect borrowernumber references Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We found that notices were going out containing raw <<borrowers.field>>. I narrowed it down to the fact we store the new patron object but don't then discard changes to get the autoincremented new borrowernumber so we were sending blank ID's to GePreparedLetter. This lead me to spot the same issue in a few other locations in the script too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32501 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144732&action=edit Bug 32501: Consistently refer to borrowernumber We had a mixture of $patron->borrowernumber, $patron->id and $borrowernumber. This patch updates the occurences of $patron->borrowernumber to just refer to $borrowernumber which is set correctly throughout the script. Test plan 1) For newly created borrowers on import check that the produced welcome notice correctly fills the borrower details from the template. 2) For updated borrowers in the import, check that the debartments still work as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32501 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm... writing a unit test for this appears to prove I'm wrong :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32501 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Any update on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org