[Bug 34108] New: When items are added on receive, item selection gets lost on editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Bug ID: 34108 Summary: When items are added on receive, item selection gets lost on editing items Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 8179 When items are added on receive, you can either set the checkboxes in the item form, or use the quantity received to set them. Then you can edit the selected items using the link in the items table. With the new multi-receive work, the checkboxes are lost between being sent to the item form and returning. If you are editing a bigger amount of items, this can be quite tedious and should not happen as sometimes it matters which items are picked (for a specific library, for a specific location etc. for partial deliveries) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- To test: * Create a basket with 'items created on receive' * Add an order line with multiple items to it * Close basket * Receive shipment * Add invoice information * Receive through receive link in the table * Check some items * Click on the "Edit" link and make some change to the item * Save --> Checkboxes have disappeared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #1)
To test: * Create a basket with 'items created on receive' * Add an order line with multiple items to it * Close basket * Receive shipment * Add invoice information * Receive through receive link in the table * Check some items
Just to clarify: following your steps I marked the orderline as including 10 items for "Perl best practices /", but I don't see a list of items to check, but the cataloguing form. Did you mean adding (say) 3 items using the form and THEN checking them? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Also, it was marked as '22.11', but depending on 8179, could you please check if this is introduced by 8179, or something we just didn't fix with the change? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When items are added on |When items are added on |receive, item selection |order, item selection gets |gets lost on editing items |lost on editing items --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, the problem here is that I confused 'on order' and 'on receive' - must have been a long day. Revised test plan: To test: * Create a basket with 'items on order' * Add an order line with multiple items to it * Close basket * Receive shipment * Add invoice information * Receive through receive link in the table * Check some items using the checkboxes * Click on the "Edit" link and make some change to the item in the form * Save --> Checkboxes have disappeared -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 22.11 was by mistake, it doesn't have the multi-receive. This was intended for master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
22.11 was by mistake, it doesn't have the multi-receive. This was intended for master.
I also verfified now that this works in 22.11 - checkboxes are kept, so this is a regression. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154218&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154218|0 |1 is obsolete| | --- Comment #8 from Sam Lau <samalau@gmail.com> --- Created attachment 154220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154220&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154220|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154225&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154225|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154262&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small patch, great effect - thanks a lot, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Missing bug 8179 on 22.11.x. Doesn't apply. Not pushing. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org