[Bug 20201] New: Silence warnings in admin/aqplan.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Bug ID: 20201 Summary: Silence warnings in admin/aqplan.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org Floody logs distracts from debugging real problems. This will clean up warnings triggered in admin/aqplan.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20185 Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- 20185 cleans up some of them while addressing perl -wc issues. This cleans up more. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 [Bug 20185] Some scripts does not pass perl -wc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71639&action=edit Bug 20201: Silence warnings triggered by admin/aqplan.pl TEST PLAN --------- 0) back up DB 1) Run the following commands on a kohadevbox: reset_all git bz apply 20185 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 2) Navigate in a staff client: Home -> Administration -> Budgets -> Edit -> Planning by libraries -- could be any of the planning, but by libraries is nicely visible on screen. 3) Run the following commands: cat /var/log/koha/kohadev/plack-error.log -- several warnings. 4) Run the following commands: git bz apply 20201 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 5) repeat step 2 and refresh the staff client page. -- this time warnings related to aqplan.pl are not there. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71639|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 72269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72269&action=edit Bug 20201: Silence warnings triggered by admin/aqplan.pl TEST PLAN --------- 0) back up DB 1) Run the following commands on a kohadevbox: reset_all git bz apply 20185 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 2) Navigate in a staff client: Home -> Administration -> Budgets -> Edit -> Planning by libraries -- could be any of the planning, but by libraries is nicely visible on screen. 3) Run the following commands: cat /var/log/koha/kohadev/plack-error.log -- several warnings. 4) Run the following commands: git bz apply 20201 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 5) repeat step 2 and refresh the staff client page. -- this time warnings related to aqplan.pl are not there. 6) run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 72269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72269 Bug 20201: Silence warnings triggered by admin/aqplan.pl Review of attachment 72269: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20201&attachment=72269) ----------------------------------------------------------------- ::: admin/aqplan.pl @@ +106,4 @@
$authcat = 'Asort1' if not defined $authcat; # defaults to Asort if no authcat given
my $budget_id = $input->param('budget_id'); +my $op = $input->param("op") // q{};
This line actually hides a bug introduced by Bug 16754. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 [Bug 26496] Budget Plan save button doesn't save plans -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org