https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163678&action=edit Bug 36394: Fix footers behaviour on the ES mapping page In the footers of the tables of the search fields and mappings, the options selected are not consistent. Additionally they are not reset correctly when a new line is added. Test plan: 0. Do not apply to recreate the problem 1. Go to the ES mapping page 2. Click tab "Bibliographic records" 3. At the bottom, notice the Yes/No dropdown lists => They are inconsistent, sometimes 'Yes', sometimes 'No' 4. Click Add => Values are kept 5. Apply this patch 6. Repeat 1, 2, 3 => No (first option) is always selected 7. Click Add after you modified some values => "No" is selected Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163678|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 163717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163717&action=edit Bug 36394: Fix footers behaviour on the ES mapping page In the footers of the tables of the search fields and mappings, the options selected are not consistent. Additionally they are not reset correctly when a new line is added. Test plan: 0. Do not apply to recreate the problem 1. Go to the ES mapping page 2. Click tab "Bibliographic records" 3. At the bottom, notice the Yes/No dropdown lists => They are inconsistent, sometimes 'Yes', sometimes 'No' 4. Click Add => Values are kept 5. Apply this patch 6. Repeat 1, 2, 3 => No (first option) is always selected 7. Click Add after you modified some values => "No" is selected Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164203&action=edit Bug 36394: Fix 'Filter' selection in new line All other fields in the new line use data-id instead of name, this fixes an inconsistency To test: 1 - Before this patch select some values, set filter to punctuation - hit 'Add' 2 - Punctuation vlaue is cleared 3 - After patch add a new line and confirm 'Filter' value is saved Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.