[Bug 7349] New: Sorting patron search result by cardnumber doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Bug #: 7349 Summary: Sorting patron search result by cardnumber doesn't work Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons AssignedTo: adrien.saurat@biblibre.com ReportedBy: adrien.saurat@biblibre.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com [Mantis ref. MT2062] In Home › Patrons › Search Results, the results are always sorted by name. There is a listbox "order by" allowing 2 choices: 1) Surname. When searching with this choice, the results are indeed sorted by surname. 2) Cardnumber. When searching with this choice, the results seem to be sorted by first name. ===== What is exactly the problem then? A) Should we be able to sort by first name/surname and then Cardnumber must be renamed to First name? B) Should we be able to sort by surname/cardnumber and then the sorting must be repaired for the cardnumber option? C) Should we be able to sort by first name/surname/cardnumber and then we add a new choice and repair cardnumber? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-12-13 14:03:55 UTC --- It looks to me like the server-side sort of the whole result set is working fine but the client-side javascript sorts by name by default. I don't think having a client-side sort makes much sense for sorted paged results, so perhaps the answer (pending a conversion to datatables) is to remove the table sorter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 --- Comment #2 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-12-13 14:55:35 UTC --- Indeed! Didn't think I would find a client-side sort here!! I don't see the point, I'll thus delete the following part: <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script> <script type="text/javascript">//<![CDATA[ $(document).ready(function() { $("#memberresultst").tablesorter({ sortList: [[1,0]], widgets: ['zebra'] }); }); //]]> </script> (it seems to work ok without it) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-12-13 15:10:12 UTC --- Created attachment 6752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6752 proposed patch Removed the tablesort JS. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 --- Comment #4 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-12-13 16:02:02 UTC --- We lose something with this patch, the widget ['zebra'] is needed to give a different color to uneven lines. I'll make another patch deleting only the "sortList: [[1,0]]," line. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 - low Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-12-13 16:16:15 UTC --- Why not move the table row coloring to the markup instead? [% IF ( loop.even ) %]<tr class="highlight">[% ELSE %]<tr>[% END %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #6 from Adrien SAURAT <adrien.saurat@biblibre.com> 2011-12-14 08:37:13 UTC --- Actually, there is already something like that in the template, the highlights look ok. No problem then, the patch is fine. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6752|0 |1 is obsolete| | --- Comment #7 from Koustubha Kale <kmkale@anantcorp.com> 2011-12-15 11:29:50 UTC --- Created attachment 6809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6809 [SIGNED-OFF] Bug 7349: corrects sort order for Patron search Sorting by cardnumber now works (removed a client-side sort, the server-side sort is enough). Signed-off-by: Koustubha Kale <kmkale@anantcorp.com> 1) Verified that before applying this patch, when searching patrons with cardnumber as order by preference, patrons are sorted ny name. 2) Verified that after applying this patch, when searching with cardnumber as order by preference, patrons are correctly sorted by cardnumber. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale@anantcorp.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-15 12:32:17 UTC --- Template only change, removes JS block only. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Passed QA |Patch Pushed --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 15:14:56 UTC --- QA comment: this patch removes code only, that can't be wrong ;-) patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 7066 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7349 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15109 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org