https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Hi Alex, Couple things here: 1 - There is a stray warn left in the patchset 2 - I would tend to agree with Mark, the subroutine should be converted to a hashref 3 - This should probably be two bugs - one to fix the note, one to add the branch option 4 - The span is lost when creating the new column, we should preserve this to retain any CSS that may affect display -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.