[Bug 23919] New: Make ISSN searchable with and without hyphen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Bug ID: 23919 Summary: Make ISSN searchable with and without hyphen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org For the ISBN we have the option to activate search with and without hyphens - but this doesn't work for ISSN. We shoudl make it work there as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |slavashishkin@gmail.com |ity.org | CC| |slavashishkin@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 [Bug 28269] Order search should be possible with ISSN too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134381&action=edit Bug 23919: Add new system preference SearchWithISSNVariations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134382&action=edit Bug 23919: Zebra search by ISSN variations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #3 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134383&action=edit Bug 23919: Add tests for biblioItems search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #4 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134384&action=edit Bug 23919: Items search by ISBN variations and ISSN variations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #5 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134385&action=edit Bug 23919: Add tests for Items search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134381|0 |1 is obsolete| | Attachment #134382|0 |1 is obsolete| | Attachment #134383|0 |1 is obsolete| | Attachment #134384|0 |1 is obsolete| | Attachment #134385|0 |1 is obsolete| | --- Comment #6 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134422&action=edit Bug 23919: Add new system preference SearchWithISSNVariations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #7 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134423&action=edit Bug 23919: Zebra search by ISSN variations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #8 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134424&action=edit Bug 23919: Add tests for biblioItems search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #9 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134425&action=edit Bug 23919: Items search by ISBN variations and ISSN variations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #10 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134426&action=edit Bug 23919: Add tests for Items search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134422|0 |1 is obsolete| | Attachment #134423|0 |1 is obsolete| | Attachment #134424|0 |1 is obsolete| | Attachment #134425|0 |1 is obsolete| | Attachment #134426|0 |1 is obsolete| | --- Comment #11 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134440&action=edit Bug 23919: Add new system preference SearchWithISSNVariations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #12 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134441&action=edit Bug 23919: Zebra search by ISSN variations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #13 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134442&action=edit Bug 23919: Add tests for biblioItems search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #14 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134443&action=edit Bug 23919: Items search by ISBN variations and ISSN variations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #15 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 134444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134444&action=edit Bug 23919: Add tests for Items search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Hello Slava, Do you have a test plan we can use when trying this patchset? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #17 from Slava Shishkin <slavashishkin@gmail.com> --- Hello Lucas, sure. 1. SearchWithISSNVariations setting is missing in the system preference 2. Apply patch 3. Check that SearchWithISSNVariations is present in the system preferences 4. Check that SearchWithISSNVariations has "search" and "don't search" parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement enables release notes| |searching by ISSN without | |using hyphens and using a | |space instead of the | |hyphen. This works in the | |advanced search (staff | |interface and OPAC) and | |item search (staff | |interface). | | | |It is enabled | |using a new system | |preference, | |SearchWithISSNVariations, | |with two options - "don't | |search" (the default), and | |"search". --- Comment #18 from David Nind <david@davidnind.com> --- Here is an updated test plan I came up with - I'll add a sign-off shortly. I hope this covers all the changes and things to test for! This enhancement enables searching by ISSN without using hyphens and using a space instead of the hyphen. This works in the advanced search (staff interface and OPAC) and item search (staff interface). It is enabled using a new system preference, SearchWithISSNVariations, with two options - "don't search" (the default), and "search". This is similar to the SearchWithISBNVariations system preference. Test plan: 1. Search for an ISSN number with a hyphen, without a hyphen (no space), and with a space instead of the hyphen (example record: 1064-3923 (record #359 in test data for koha-testing-docker)): (a) standard search (staff inerface and OPAC) => result found with hyphen, not found if no hyphen or space used [note: no change after patch applied] (b) ISSN keyword field in the advanced search (staff interface and OPAC) => result found, not found if no hyphen or space used (c) item search in the staff interface (acces from Search drop down list in the navigation at the top of the page > Item search > field search - change to ISSN) => result found, not found if no hyphen or space used 2. Search for SearchWithISSNVariations in the system preferences search => no system preference found with that name. 3. Apply the patch, update the database (updatedatabase), flush_memcached, restart_all (I also reindexed - not sure whether this is necessary: koha-rebuild-zebra -f -v kohadev) (koha-testing-docker). 4. Search for the system preference SearchWith - system preference SearchWithISSNVariations found, with default setting set as "don't search". 5. Check that the text for the system preference reads well (it uses similar wording to the SearchWithISBNVariations system preference). 6. Repeat step 1 with SearchWithISSNVariations set as "don't search" => current behavior, that is, no results found if no hyphen or space used. 7. Repeat step 1 with SearchWithISSNVariations set as "search" => should now find the record with and without the hyphen and with a space instead of the hyphen for steps 1(b) and 1(c). 8. Run the tests - these should pass: . prove t/Search/buildQuery.t . prove t/db_dependent/Items.t 8. Sign off. Notes: - I think the QA Team will probably want the commit message(s?) to follow the guidelines for the descriptions (see https://wiki.koha-community.org/wiki/Commit_messages#Bug.2Ffeature_descripti...) - Maybe an additional enhancement (as a separate bug) would be to make this work when searching on the ISSN number in the serials search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134440|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 135288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135288&action=edit Bug 23919: Add new system preference SearchWithISSNVariations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134441|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 135289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135289&action=edit Bug 23919: Zebra search by ISSN variations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134442|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 135290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135290&action=edit Bug 23919: Add tests for biblioItems search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134443|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 135291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135291&action=edit Bug 23919: Items search by ISBN variations and ISSN variations Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134444|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 135292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135292&action=edit Bug 23919: Add tests for Items search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #24 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #0)
For the ISBN we have the option to activate search with and without hyphens - but this doesn't work for ISSN. We shoudl make it work there as well.
Curious about this one... Since Zebra normalizes the data by stripping out hyphens, it shouldn't be relevant for Zebra? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #24)
(In reply to Katrin Fischer from comment #0)
For the ISBN we have the option to activate search with and without hyphens - but this doesn't work for ISSN. We shoudl make it work there as well.
Curious about this one...
Since Zebra normalizes the data by stripping out hyphens, it shouldn't be relevant for Zebra?
IIRC if you search without the hyphen, you will not find the case with hyphen as it's treated as a space (or it might be in our installations, but it looks like we are not the only ones) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #26 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #25)
IIRC if you search without the hyphen, you will not find the case with hyphen as it's treated as a space (or it might be in our installations, but it looks like we are not the only ones)
Ahhh right. My mistake. That makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135288|0 |1 is obsolete| | Attachment #135289|0 |1 is obsolete| | Attachment #135290|0 |1 is obsolete| | Attachment #135291|0 |1 is obsolete| | Attachment #135292|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138311&action=edit Bug 23919: Add new system preference SearchWithISSNVariations Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138312&action=edit Bug 23919: Zebra search by ISSN variations Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138313&action=edit Bug 23919: Add tests for biblioItems search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138314&action=edit Bug 23919: Items search by ISBN variations and ISSN variations Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138315&action=edit Bug 23919: Add tests for Items search by ISBN and ISSN with variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- No mention of Elasticsearch in the test plan? Does this already work on Elasticsearch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a search expansion, not an indexing change - searching for different variations. The search engine should not matter :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138480&action=edit Bug 23919: (QA follow-up) Tidy query build code This is really opinionated, but I found this to be much cleaner to read and thought it was worth pusing as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31278 [Bug 31278] ISBN and ISSN searching should quote the query terms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #36 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 [Bug 33514] breaks ISBN search in item search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sad to say, but adding this to item search was not a great idea :( Item search is SQL based, not a search engine, which changes things quite a bit. We are exploding the search now with up to 4 forms of ISBN into something like: isbn like 'isbn1' or isbn like 'isbn2' ... But: We are not truncating. As soon as there is more than one ISBN or ISSN (these are repeatable fields) or the library actually follows MARC21 standard adding ISBD punctuation, this fails. We store in biblioitems.isbn like this: isbn1 ; | isbn2 ; | isbn3. isbn1. This also seems to create quite a performance issue on big databases and it can't be turned off separately from the normal search. I've filed bug 33514. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/659 CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #37)
I am sad to say, but adding this to item search was not a great idea :(
Item search is SQL based, not a search engine, which changes things quite a bit.
We are exploding the search now with up to 4 forms of ISBN into something like:
isbn like 'isbn1' or isbn like 'isbn2' ...
But: We are not truncating.
As soon as there is more than one ISBN or ISSN (these are repeatable fields) or the library actually follows MARC21 standard adding ISBD punctuation, this fails. We store in biblioitems.isbn like this:
isbn1 ; | isbn2 ; | isbn3. isbn1.
This also seems to create quite a performance issue on big databases and it can't be turned off separately from the normal search.
I've filed bug 33514.
Can you please address bug 33514? In the meanwhile should we remove this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #38)
(In reply to Katrin Fischer from comment #37)
I am sad to say, but adding this to item search was not a great idea :(
Item search is SQL based, not a search engine, which changes things quite a bit.
We are exploding the search now with up to 4 forms of ISBN into something like:
isbn like 'isbn1' or isbn like 'isbn2' ...
But: We are not truncating.
As soon as there is more than one ISBN or ISSN (these are repeatable fields) or the library actually follows MARC21 standard adding ISBD punctuation, this fails. We store in biblioitems.isbn like this:
isbn1 ; | isbn2 ; | isbn3. isbn1.
This also seems to create quite a performance issue on big databases and it can't be turned off separately from the normal search.
I've filed bug 33514.
Can you please address bug 33514? In the meanwhile should we remove this?
What do you mean with "address"? It's all explained there as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I was actually asking the author of 23919 (here) to fix the bug they introduced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can you please help on the follow-up bug report? See bug 33514. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #41)
Can you please help on the follow-up bug report? See bug 33514.
No action so far. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org