[Bug 14377] New: Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Bug ID: 14377 Summary: Indicate that a record is suppressed in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Would be nice if in the staff client there was some indication that a record you are viewing is suppressed in the OPAC. This would be an XSLT customization. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |wsalesky@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #1 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 42424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42424&action=edit Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set to 1. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff view. 3) Find or create a record with MARC tags 942$n=1 4) Check for “Suppressed in OPAC” at the top of the results div and at the top of the full record display. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #2 from Winona Salesky <wsalesky@gmail.com> --- 942 is wrapped with id="suppressed_opac" to make individual styling possible. (In reply to Winona Salesky from comment #1)
Created attachment 42424 [details] [review] Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set to 1.
Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff view. 3) Find or create a record with MARC tags 942$n=1 4) Check for “Suppressed in OPAC” at the top of the results div and at the top of the full record display.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 42424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42424 Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set to 1. Hi Winona, can you please use a class instead of an id for the result lists as the element can show up there repeatedly? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #4 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 42436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42436&action=edit Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set to 1. Changed id="suppressed_opac" to class="suppressed_opac". Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff view. 3) Find or create a record with MARC tags 942$n=1 4) Check for “Suppressed in OPAC” at the top of the results div and at the top of the full record display. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #5 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 42709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42709&action=edit Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1. Includes class="suppressed_opac" for library specific styles. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #6 from Winona Salesky <wsalesky@gmail.com> --- (In reply to Winona Salesky from comment #5)
Created attachment 42709 [details] [review] Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1.
Includes class="suppressed_opac" for library specific styles.
Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff view. 3) Find or create a record with MARC tags 942$n=1 4) Check for “Suppressed in OPAC” at the top of the results div and at the top of the full record display. Recommended custom CSS: .suppressed_opac { color:red; font-size:1.25em; font-weight:bold; float:right; margin-right:2em; clear:none; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42709|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 43026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43026&action=edit Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1. Includes class="suppressed_opac" for library specific styles. Suggested css: .suppressed_opac { color:red; font-size:1.25em; font-weight:bold; float:right; margin-right:2em; clear:none; } Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #8 from Nick Clemens <nick@quecheelibrary.org> --- Works as expected. Style note: Without recommended CSS the 'Suppressed in Opac' in search results is next to result number and above title/author. I think the default location should be below these two if possible -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this last patch doesn't work for me. I have reindexed and the MARC view shows: 942 _2ddc _cBK _n1 <datafield tag="942" ind1=" " ind2=" "> <subfield code="2">ddc</subfield> <subfield code="c">BK</subfield> <subfield code="n">1</subfield> </datafield> I think the test doesn't work quite right, but I haven't figured out why: test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']" Can you see, what might go wrong here? I am also not a fan of showing the bibnumber, I think it's more likely to confuse than being helpful. I'd like it better if we showed only the text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #10 from Winona Salesky <wsalesky@gmail.com> --- Would you mind sending me your marcxml test record to test? Thanks, -Winona wsalesky@gmail.com (In reply to Katrin Fischer from comment #9)
Hm, this last patch doesn't work for me. I have reindexed and the MARC view shows:
942 _2ddc _cBK _n1
<datafield tag="942" ind1=" " ind2=" "> <subfield code="2">ddc</subfield> <subfield code="c">BK</subfield> <subfield code="n">1</subfield> </datafield>
I think the test doesn't work quite right, but I haven't figured out why: test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']"
Can you see, what might go wrong here?
I am also not a fan of showing the bibnumber, I think it's more likely to confuse than being helpful. I'd like it better if we showed only the text.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #11 from Winona Salesky <wsalesky@gmail.com> --- I am unable to reproduce this issue. The record you sent me runs fine on my system. Can you give me any additional details about how you are testing this patch? Also, if you are comfortable looking in the xslt could you try changing the test (line 94 on MARC21slim2intranetDetail.xsl) to: test="marc:datafield[@tag=942][normalize-space(marc:subfield[@code='n']) = '1'] An additional tester may also be helpful. Thanks, -Winona (In reply to Katrin Fischer from comment #9)
Hm, this last patch doesn't work for me. I have reindexed and the MARC view shows:
942 _2ddc _cBK _n1
<datafield tag="942" ind1=" " ind2=" "> <subfield code="2">ddc</subfield> <subfield code="c">BK</subfield> <subfield code="n">1</subfield> </datafield>
I think the test doesn't work quite right, but I haven't figured out why: test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']"
Can you see, what might go wrong here?
I am also not a fan of showing the bibnumber, I think it's more likely to confuse than being helpful. I'd like it better if we showed only the text.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #12 from Marc Véron <veron@veron.ch> --- Some testing from my part: If I put an additional blank after the 1 in 942n, the record is suppressed in OPAC (with syspref 'OpacSuppression set to 'Hide'), but the message does not show up on the staff detail view. If I then add the normalize-space function to the XSL as described in comment #11 the message appears. If I have use the authorized value YesNo, it does not work. I tweaked the xsl to display the 942nvalue, and it is Yes instead of 1 As Katrin mentioned on IRC this is a problem, because the auhorized values are translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #13 from Marc Véron <veron@veron.ch> --- Workaround and/or possible solution: I created an authorized value category ONE_ZERO and gave it 0 / 1 for the values and for all descriptions. Then I linked it with 942 n. Display of suppression message is fine. And it displays 1 or 0 correctly while editing 942 n for records that formerly had YES_NO values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think 0/1 as the description is not very friendly for the cataloger and might lead to some confusion. Another suggestion: We could use the mechanism that makes system preferences available in the XSLT. We could create a variable to store the description that matches the authorised value category linked to 942$n for the value 1. And then base the check on that. Does that make sense? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #15 from Winona Salesky <wsalesky@gmail.com> --- This would work for me. I'm afraid I am still using learning the ins and outs of Koha, and did not realize there were other possible values to 942$n. -Winona (In reply to Katrin Fischer from comment #14)
Hm, I think 0/1 as the description is not very friendly for the cataloger and might lead to some confusion. Another suggestion: We could use the mechanism that makes system preferences available in the XSLT. We could create a variable to store the description that matches the authorised value category linked to 942$n for the value 1. And then base the check on that. Does that make sense? :)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #16 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Katrin Fischer from comment #14)
Hm, I think 0/1 as the description is not very friendly for the cataloger and might lead to some confusion. Another suggestion: We could use the mechanism that makes system preferences available in the XSLT. We could create a variable to store the description that matches the authorised value category linked to 942$n for the value 1. And then base the check on that. Does that make sense? :)
I don't think I followed that well ; ) Here's what I'm thinking: 1) Add a new system preference OpacSuppressionValue that defines the value ( 1, the Authorised Value description for 1, default of 1 if not set ). So this value could be 1, Yes, Si, Oui or what have you. 2) Pass this new pref to the XSLT 3) Compare against the pref value rather than just '1' Is this what you are thinking Katrin? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I think we don't need a system preference, because we can find out what the right value is within Koha: 1) Look up, which authorised value is linked to 942$n 2) Look up for the authorised value, which description is used for the value 1 Does this make sense? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and the value you get, you pass into the XSLT using a similar mechanism as for the system preferences. And later on we can enhance it to also work for mulitple translations, when a similar mechanism as proposed in 14100 is implemented for authorised values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Karl Holten <kholten@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten@switchinc.org --- Comment #19 from Karl Holten <kholten@switchinc.org> --- Hi, we're the institution that requested the bibnumber show up. Our staff do a lot of searching but standard numbers such as the bib record number, OCLC number, barcode, ISSN. It's a more direct way to search in Koha which tends to be very keyword heavy. Staff want to get fewer results, not more or even multiple. Seeing the record number also helps identify it quickly versus the title which can be more generic and/or be one of other similar titles. Anyway, that's the reason we made that request. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Karl, with this patch the bibnumber will only show for suppressed records - that's what didn't make so much sense to me. I am not opposed at all to add the bibnumber to display in general, but then maybe on a separate bug as it doesn't really fit here :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43026|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45564&action=edit Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1. Includes class="suppressed_opac" for library specific styles. Suggested css: .suppressed_opac { color:red; font-size:1.25em; font-weight:bold; float:right; margin-right:2em; clear:none; } Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45565&action=edit Bug 14377 [QA Followup] - Use true value description for authorised value Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45565|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45566&action=edit Bug 14377 [QA Followup] - Use true value description for authorised value Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45568&action=edit Bug 14377 [QA Followup] - Remove biblionumber, move message to below title for search results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |frederic@tamil.fr, | |gaetan.boisson@biblibre.com | |, | |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is not marcflavour independent: 942$n is hardcoded, so it won't work for UNIMARC The XSLT changes have been done for MARC21 only, if NORMARC uses 942$n also, it would be easy to c/p the changes to the according XSLT files. Does a UNIMARC user want to provide a patch for UNIMARC XSLT? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46900&action=edit Bug 14377 [QA Followup] - Add support for NORMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Failed QA |Signed Off --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #25)
This is not marcflavour independent: 942$n is hardcoded, so it won't work for UNIMARC The XSLT changes have been done for MARC21 only, if NORMARC uses 942$n also, it would be easy to c/p the changes to the according XSLT files.
Does a UNIMARC user want to provide a patch for UNIMARC XSLT?
As far as I can tell, UNIMARC does not have record suppression support! I based this on the fact that I can't find any reference to the Suppress index in marc_defs/unimarc, so unless I'm mistaken, it's a non-issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the 'problem' with UNIMARC was that there was no default standard field chosen. The systempreference description used to say something about adding a suppress index. So that might be more complicated - as we don't know what people have already been using and not sure how hard it would be to pick a new default fiel for that purpose in UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I will let a MARC21 user to QA this patchset, but I am pretty sure we need a unless UNIMARC statement in transformMARCXML4XSLT. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46993&action=edit Bug 14377 [QA Followup] - Don't do 942$n processing for UNIMARC -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org