[Bug 32437] New: When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Bug ID: 32437 Summary: When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32054 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054 [Bug 32054] GetImportRecordMatches returns the wrong match when passed 'best only' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144538&action=edit Bug 32437: Cleanup script This patch: - fixes some indentation - flips unless-else to if-else for readability - expands some comments for clarity - removes unused biblioitemnum variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144539&action=edit Bug 32437: Add Objects for ImportAuths This patch: 1 - Adds an atomic update to add a primary key to import_auths table 2 - Adds objects for Koha::Import::Records::Auths 3 - Adds tests for import auth and biblio objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144540&action=edit Bug 32437: Add replace method to Koha::Import::Record objects This patch adds a replace routine to Koha::Import::Record - largely copying and updating code from C4::ImportBatch To test: prove t/db_dependent/Koha/Import/Records.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144541&action=edit Bug 32437: Honor overlay setting in staged batch when adding to a basket This patch uses the replace method added in last patch to ensure records are overlayed when added to a basket To test: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten 10 - Apply patch 11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record' 12 - Add to basket from the staged file and save 13 - Confirm record not overlayed when not reuqested 14 - Stage file, match on KohaBiblio, set action if mathc record found to 'Replace existing...' 15 - Add to basket from staged file and save 16 - Confirm the record is updated to 'New and improved!' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144538|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144573&action=edit Bug 32437: Cleanup script This patch: - fixes some indentation - flips unless-else to if-else for readability - expands some comments for clarity - removes unused biblioitemnum variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144539|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144574&action=edit Bug 32437: Add Objects for ImportAuths This patch: 1 - Adds an atomic update to add a primary key to import_auths table 2 - Adds objects for Koha::Import::Records::Auths 3 - Adds tests for import auth and biblio objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144540|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144575&action=edit Bug 32437: Add replace method to Koha::Import::Record objects This patch adds a replace routine to Koha::Import::Record - largely copying and updating code from C4::ImportBatch To test: prove t/db_dependent/Koha/Import/Records.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144541|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144576&action=edit Bug 32437: Honor overlay setting in staged batch when adding to a basket This patch uses the replace method added in last patch to ensure records are overlayed when added to a basket To test: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten 10 - Apply patch 11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record' 12 - Add to basket from the staged file and save 13 - Confirm record not overlayed when not reuqested 14 - Stage file, match on KohaBiblio, set action if mathc record found to 'Replace existing...' 15 - Add to basket from staged file and save 16 - Confirm the record is updated to 'New and improved!' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144573|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145223&action=edit Bug 32437: Cleanup script This patch: - fixes some indentation - flips unless-else to if-else for readability - expands some comments for clarity - removes unused biblioitemnum variable Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144574|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145224&action=edit Bug 32437: Add Objects for ImportAuths This patch: 1 - Adds an atomic update to add a primary key to import_auths table 2 - Adds objects for Koha::Import::Records::Auths 3 - Adds tests for import auth and biblio objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144575|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145225&action=edit Bug 32437: Add replace method to Koha::Import::Record objects This patch adds a replace routine to Koha::Import::Record - largely copying and updating code from C4::ImportBatch To test: prove t/db_dependent/Koha/Import/Records.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144576|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145226&action=edit Bug 32437: Honor overlay setting in staged batch when adding to a basket This patch uses the replace method added in last patch to ensure records are overlayed when added to a basket To test: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten 10 - Apply patch 11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record' 12 - Add to basket from the staged file and save 13 - Confirm record not overlayed when not reuqested 14 - Stage file, match on KohaBiblio, set action if mathc record found to 'Replace existing...' 15 - Add to basket from staged file and save 16 - Confirm the record is updated to 'New and improved!' Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Cannot finish right now, happy to continue next week.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145223|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147677&action=edit Bug 32437: Cleanup script This patch: - fixes some indentation - flips unless-else to if-else for readability - expands some comments for clarity - removes unused biblioitemnum variable Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145224|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147678&action=edit Bug 32437: Add Objects for ImportAuths This patch: 1 - Adds an atomic update to add a primary key to import_auths table 2 - Adds objects for Koha::Import::Records::Auths 3 - Adds tests for import auth and biblio objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145225|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147679&action=edit Bug 32437: Add replace method to Koha::Import::Record objects This patch adds a replace routine to Koha::Import::Record - largely copying and updating code from C4::ImportBatch To test: prove t/db_dependent/Koha/Import/Records.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145226|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147680&action=edit Bug 32437: Honor overlay setting in staged batch when adding to a basket This patch uses the replace method added in last patch to ensure records are overlayed when added to a basket To test: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten 10 - Apply patch 11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record' 12 - Add to basket from the staged file and save 13 - Confirm record not overlayed when not reuqested 14 - Stage file, match on KohaBiblio, set action if mathc record found to 'Replace existing...' 15 - Add to basket from staged file and save 16 - Confirm the record is updated to 'New and improved!' Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 147681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147681&action=edit Bug 32437: (QA follow-up) Change to replace POD Making it more visible that this also applies to authority records. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. Still looking a bit at the dbrev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha/Schema/Result/ImportAuth.pm | 23 ++++++-- Koha/Schema/Result/ImportRecord.pm | 12 ++--- These files should be removed from the patch and be on a separate DO NOT PUSH-one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- } elsif( !primary_key_exists('import_auths','import_record_id') ){ say $out "Found an existing PRIMARY KEY on import_auths table"; say $out "You must delete this key and replace it with a key on import_record_id"; } else { say $out "PRIMARY KEY import_record_id on import_auths already exists"; Since we assume in the schema that the primary key is import_record_id, we should bail out in the middle clause where we find another PK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Temporary switch to FQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147677|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148270&action=edit Bug 32437: Cleanup script This patch: - fixes some indentation - flips unless-else to if-else for readability - expands some comments for clarity - removes unused biblioitemnum variable Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147678|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148271&action=edit Bug 32437: Add Objects for ImportAuths This patch: 1 - Adds an atomic update to add a primary key to import_auths table 2 - Adds objects for Koha::Import::Records::Auths 3 - Adds tests for import auth and biblio objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147679|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148272&action=edit Bug 32437: Add replace method to Koha::Import::Record objects This patch adds a replace routine to Koha::Import::Record - largely copying and updating code from C4::ImportBatch To test: prove t/db_dependent/Koha/Import/Records.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147680|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148273&action=edit Bug 32437: Honor overlay setting in staged batch when adding to a basket This patch uses the replace method added in last patch to ensure records are overlayed when added to a basket To test: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten 10 - Apply patch 11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record' 12 - Add to basket from the staged file and save 13 - Confirm record not overlayed when not reuqested 14 - Stage file, match on KohaBiblio, set action if mathc record found to 'Replace existing...' 15 - Add to basket from staged file and save 16 - Confirm the record is updated to 'New and improved!' Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147681|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148274&action=edit Bug 32437: (QA follow-up) Change to replace POD Making it more visible that this also applies to authority records. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148275&action=edit Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148276&action=edit Bug 32437: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148275|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148277&action=edit Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148270|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148300&action=edit Bug 32437: Cleanup script This patch: - fixes some indentation - flips unless-else to if-else for readability - expands some comments for clarity - removes unused biblioitemnum variable Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148271|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148301&action=edit Bug 32437: Add Objects for ImportAuths This patch: 1 - Adds an atomic update to add a primary key to import_auths table 2 - Adds objects for Koha::Import::Records::Auths 3 - Adds tests for import auth and biblio objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148272|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148302&action=edit Bug 32437: Add replace method to Koha::Import::Record objects This patch adds a replace routine to Koha::Import::Record - largely copying and updating code from C4::ImportBatch To test: prove t/db_dependent/Koha/Import/Records.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148273|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148303&action=edit Bug 32437: Honor overlay setting in staged batch when adding to a basket This patch uses the replace method added in last patch to ensure records are overlayed when added to a basket To test: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten 10 - Apply patch 11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record' 12 - Add to basket from the staged file and save 13 - Confirm record not overlayed when not reuqested 14 - Stage file, match on KohaBiblio, set action if mathc record found to 'Replace existing...' 15 - Add to basket from staged file and save 16 - Confirm the record is updated to 'New and improved!' Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148274|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148304&action=edit Bug 32437: (QA follow-up) Change to replace POD Making it more visible that this also applies to authority records. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148276|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148305&action=edit Bug 32437: DO NOT PUSH - Schema Updates Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148277|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148306&action=edit Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #40 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #41 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org