[Bug 30979] New: Add ability for opac users to checkout to themselves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Bug ID: 30979 Summary: Add ability for opac users to checkout to themselves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org In some trusted environments libraries would like their users to self-issue without having to use the SCO or SIP checkouts. i.e. once logged in a user should have the ability to check out to themselves much like they already have the option to renew and place holds etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30444 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability for opac users |Add ability for OPAC users |to checkout to themselves |to checkout to themselves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #0)
In some trusted environments libraries would like their users to self-issue without having to use the SCO or SIP checkouts. i.e. once logged in a user should have the ability to check out to themselves much like they already have the option to renew and place holds etc.
I've had a number of libraries over the years who would be keen to make use of this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Work in progress over at https://gitlab.com/mrenvoize/Koha/-/tree/bug_30979. It's all API driven with a Modal interface for interactions. So far it will look up an item from it's barcode, check it's availability and give various feedback based on that availability and then attempt to checkout (or require confirm is availability suggests that's required). The checkout endpoint is still a work in progress. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/mrenvoiz | |e/Koha/-/tree/bug_30979 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://gitlab.com/mrenvoize/Koha/-/tree/bug_30979 even -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139131&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139132&action=edit Bug 30979: Add public items lookup route This patch adds a /public equivilent to the item listing endpoint. This allows us to search for an item by it's external_id (barcode). Test plan 1. Apply patch 2. Perform a GET on /api/v1/public/items?external_id=some_barcode 3. Confirm that the above enpoint correctly returns items that should be visible in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139133&action=edit Bug 30979: Checkout API's This patch adds an initial framework for adding/migrating AddIssue from C4::Circulation into Koha::Checkout... but that feels a bit over scope. Also.. should we do all the checks and return failure in Koha::REST::V1::Checkout->add such that we require a new special header for the equivilent of 'confirm' in the controller script route.. Should we accept an external_id in the checkout add route.. or chain two ajax requests such that the first looks up the item from it's external_id and then the second calls checkout upon it? Should we have a 'CanBookBeIssued' equivilent on the API? Bug 30979: Add confirmation token to API This patch adds the creation of a confirmation token to the get_availability method and then adds a test for the presence of that same token later in the checkout routine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139134&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode, check for item existance and availability and then check the item out after any confirmations have been displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So, this clearly needs a bit more polishing (and unit tests for the new api routes).. but I'd love to get some feedback.. all the basics are working including a confirmation flow checkouts that require it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 maalej@effective-webwork.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maalej@effective-webwork.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #9 from Hugo Agud <hagud@orex.es> --- I have installed the patch in a sandbox, I have enabled syspref OpacTrustedCheckout I. have logged to the opac I am not able to see at opac-detail, opac-results or in my account the way to seld check out I have also checked that circ rules are configured I have also checked that the homebranch of books and users are the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- I had a go at testing what has been done so are - the basic checkout seems to work well. An example use case could be a small corporate/in house library for an organisation without dedicated/full time library staff that wants to let staff "self-service" so they can checkout and return items without having to use a manual process (such as recording items checked out or in on a register at the door). Here are my testing notes (using KTD): Setup 1. Apply patches, updatedatabase, flush_memcached, restart_all 2. Enable OpacTrustedCheckout system preference Testing the API 1. Get details of items for a record: - Visit http://127.0.0.1:8080/api/v1/public/items?external_id=39999000005097 ==> should return details for the item Test the self-checkout feature: 1. Go to the OPAC home page 2. Login as a patron (in this case I used koha), and note that in the OPAC header there is now a Self checkout option after Cart and Lists 3. Click on Self checkout ==> window pops up asking you to enter a barcode 4. Enter a barcode for an item that is available, for example: 39999000006094 ==> Message should say: "Item '39999000006094' was checked out", and an option to enter another barcode, as well as Submit and Close buttons 5. Click close and check your account > your summary: item checked out should be listed 6. Repeat step 4 with the same barcode, this time the result should be: ==> Message says: "Item '39999000006094' needs confirmation for the following: RENEW_ISSUE" . Click Confirm (note: currently does nothing, if this is allowed as can renew already from the your summary page) 7. Checkout an item to another patron using the staff interface . Example: checked out 39999000011418 to Mary Burton 9. Use the self-checkout to try and checkout this item: ==> Message says: "Item '39999000011418' needs confirmation for the following: ISSUED_TO_ANOTHERissued_borrowernumberissued_cardnumberissued_firstnameissued_surname" . Click confirm (note: currently does nothing) 10. Use the self-checkout to try and checkout an item on hold: . Place a hold for an item using the staff interface. Example: Placed a record level hold for Programming the Perl DBI (biblionumber = 13) ==> Message says "Item '39999000000559' needs confirmation for the following: RESERVEDresborrowernumberresbranchcoderescardnumberreserve_idresfirstnameresreservedateressurname" with Confirm and Close buttons . Click confirm (note: currently does nothing) 11. Use the self checkout to try and checkout an item on hold for your OPAC patron: . Place a record-level hold for an item using the staff interface (used Perl Better Practices, biblionumber = 19) . Check in an item for the record and confirm the hold (used 39999000008036), should show status as awaiting pickup . Use the self checkout to try and checkout this item to the patron the hold was placed for (39999000008036 and patron koha in this instance) ==> Item should be successfully checked out with message "Item '39999000008036' was checked out", with options to enter another barcode, Submit and Close buttons ==> Click close and check your account > your summary: item checked out should be listed 12. Try and checkout and item not for loan: . Update an item for a record so that is not for loan . Try and checkout using the self-checkout ==> message says: "Item '39999000005158' cannot be checked out for the following reasons: NOT_FOR_LOANitem_notforloan" 13. Try and checkout an item recorded as Withdrawn: . Update an item for a record so that it is withdrawn . Try and checkout using the self-checkout ==> message says: "Item '39999000005097' cannot be checked out for the following reasons: WTHDRAWN" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the comprehensive testing David. It appears some of the confirmation code got lost during rebases.. I've fixed that now and will upload an updated patchset soon. You've also highlighted lots of cases where I've not yet fully dealt with error conditions.. I'll work through those now too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139131|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141274&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139132|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141275&action=edit Bug 30979: Add public items lookup route This patch adds a /public equivilent to the item listing endpoint. This allows us to search for an item by it's external_id (barcode). Test plan 1. Apply patch 2. Perform a GET on /api/v1/public/items?external_id=some_barcode 3. Confirm that the above enpoint correctly returns items that should be visible in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139133|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141276&action=edit Bug 30979: Checkout API's This patch adds an initial framework for adding/migrating AddIssue from C4::Circulation into Koha::Checkout... but that feels a bit over scope. Also.. should we do all the checks and return failure in Koha::REST::V1::Checkout->add such that we require a new special header for the equivilent of 'confirm' in the controller script route.. Should we accept an external_id in the checkout add route.. or chain two ajax requests such that the first looks up the item from it's external_id and then the second calls checkout upon it? Should we have a 'CanBookBeIssued' equivilent on the API? Bug 30979: Add confirmation token to API This patch adds the creation of a confirmation token to the get_availability method and then adds a test for the presence of that same token later in the checkout routine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139134|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141277&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode, check for item existance and availability and then check the item out after any confirmations have been displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141278&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141279&action=edit Bug 30979: Handle more failure cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141279|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141300&action=edit Bug 30979: Handle more failure cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #19 from David Nind <david@davidnind.com> --- I tested again using KTD and updated message changes for the test plan. I also added a test for when the patron account has outstanding charges. Setup 1. Apply patches, updatedatabase, flush_memcached, restart_all 2. Enable OpacTrustedCheckout system preference Testing the API 1. Get details of items for a record: - Visit http://127.0.0.1:8080/api/v1/public/items?external_id=39999000005097 ==> should return details for the item Test the self-checkout feature: 1. Go to the OPAC home page 2. Login as a patron (in this case I used koha), and note that in the OPAC header there is now a Self checkout option after Cart and Lists 3. Click on Self checkout ==> window pops up asking you to enter a barcode 4. Enter a barcode for an item that is available, for example: 39999000006094 ==> Message should say: "Item '39999000006094' was checked out", and an option to enter another barcode, as well as Submit and Close buttons 5. Click close and check your account > your summary: item checked out should be listed 6. Repeat step 4 with the same barcode, this time the result should be: ==> Message says: "Item will be renewed" . Click Confirm (note: currently this appears to do nothing - stays on the same screen - it does renew the item though (see your summary)) 7. Checkout an item to another patron using the staff interface . Example: checked out 39999000011418 to Mary Burton 9. Use the self-checkout to try and checkout this item: ==> Message says: "This item appears to be checked out to another patron, please return it to the desk Message code 'issued_borrowernumber' with data '49' Message code 'issued_cardnumber' with data '23529000651225' Message code 'issued_firstname' with data 'Mary' Message code 'issued_surname' with data 'Burton'" . Click confirm (note that nothing appears to change, however: item is returned, then checked out - no longer checked out to Mary) 10. Use the self-checkout to try and checkout an item on hold: . Place a hold for an item for another patron using the staff interface. Example: Placed a record level hold for Programming the Perl DBI (biblionumber = 13) ==> Message says: "This item appears to be reserved for another patron, please return it to the desk Message code 'resborrowernumber' with data '49' Message code 'resbranchcode' with data 'MPL' Message code 'rescardnumber' with data '23529000651225' Message code 'reserve_id' with data '1' Message code 'resfirstname' with data 'Mary' Message code 'resreservedate' with data '2022-10-05' Message code 'ressurname' with data 'Burton'" Has Confirm and Close buttons . Click confirm (checks item out to you, hold is still in place for the other patron) 11. Use the self checkout to try and checkout an item on hold for your OPAC patron: . Place a record-level hold for an item using the staff interface (used Perl Better Practices, biblionumber = 19) . Check in an item for the record and confirm the hold (used 39999000008036), should show status as awaiting pickup . Use the self checkout to try and checkout this item to the patron the hold was placed for (39999000008036 and patron koha in this instance) ==> Item should be successfully checked out with message "Item '39999000008036' was checked out", with options to enter another barcode, Submit and Close buttons ==> Click close and check your account > your summary: item checked out should be listed 12. Try and checkout and item not for loan: . Update an item for a record so that is not for loan . Try and checkout using the self-checkout ==> message says: "This item is not normally for loan, please select another or ask at the desk Message code 'item_notforloan' with data '1'" Has Submit and Close buttons ==> Item does not check out, as expected. 13. Try and checkout an item recorded as Withdrawn: . Update an item for a record so that it is withdrawn . Try and checkout using the self-checkout ==> message says: "This item is marked withdrawn, please select another or ask at the desk" 14. Add a manual charge for the koha patron then try and check out an item. . Add a manual invoice for the koha patron of $20. ==> message says: "Message code 'DEBT' with data '20'" ==> Does not checkout item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- I haven't looked into the code yet but I was wondering how you work out the branch for the checkout. For a multi-branch library, they might need to self-checkout from multiple different locations. Do we just use the holdingbranch of the item in that case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141274|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145264&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141275|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145265&action=edit Bug 30979: Add public items lookup route This patch adds a /public equivilent to the item listing endpoint. This allows us to search for an item by it's external_id (barcode). Test plan 1. Apply patch 2. Perform a GET on /api/v1/public/items?external_id=some_barcode 3. Confirm that the above enpoint correctly returns items that should be visible in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145266&action=edit Bug 30979: Public checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/public/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout endpoint at `/public/checkouts` that accepts a POST request with checkout details including item_id and a confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141278|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145267&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141277|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145268&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Cook from comment #20)
I haven't looked into the code yet but I was wondering how you work out the branch for the checkout.
For a multi-branch library, they might need to self-checkout from multiple different locations. Do we just use the holdingbranch of the item in that case?
I don't touch the existing code for that at all.. we're calling 'AddIssue' within the API here and that uses the logic in '_GetCircControlBranch'.. which I believe looks at environment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and tidied up a bit.. but I still need to take care of some of the reserves and checked out to another user related issues.. I feel we're leaking some details we shouldn't be on the public API at the current state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145277&action=edit Bug 30979: Remove data from publically facing API The availability API was leaking some patron information for certain cases. This bug adds a deny-list to remove the leaked fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145264|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145280&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145265|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145281&action=edit Bug 30979: Add public items lookup route This patch adds a /public equivilent to the item listing endpoint. This allows us to search for an item by it's external_id (barcode). Test plan 1. Apply patch 2. Perform a GET on /api/v1/public/items?external_id=some_barcode 3. Confirm that the above enpoint correctly returns items that should be visible in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145266|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145282&action=edit Bug 30979: Public checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/public/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout endpoint at `/public/checkouts` that accepts a POST request with checkout details including item_id and a confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145277|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145283&action=edit Bug 30979: Remove data from publically facing API The availability API was leaking some patron information for certain cases. This bug adds a deny-list to remove the leaked fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145267|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145284&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145268|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145285&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Lots of little refinements went in this time.. I reckon we're back to NSO. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #36 from David Nind <david@davidnind.com> --- Updated test plan I used (using KTD). Setup 1. Apply patches, updatedatabase, flush_memcached, restart_all 2. Enable OpacTrustedCheckout system preference Testing the API 1. Get details of items for a record: - Visit http://127.0.0.1:8080/api/v1/public/items?external_id=39999000005097 ==> should return details for the item Test the self-checkout feature: 1. Go to the OPAC home page. 2. Login as a patron (in this case I used koha), and note that in the OPAC header there is now a Self checkout option after Cart and Lists. 3. Click on Self checkout ==> window pops up asking you to enter a barcode. 4. Enter a barcode for an item that is available, for example: 39999000006094 ==> Message should say: "Item '39999000006094' was checked out", and an option to enter another barcode, as well as Submit and Close buttons. 5. Click close and check your account > your summary: item checked out should be listed. 6. Repeat step 4 with the same barcode, this time the result should be: ==> Message says: "Item will be renewed" . Click Confirm ==> Message says "Item '39999000006094' was checked out". There is also an input box to enter another item barcode, and there may also be a list of barcodes checked out and the due date. 7. Checkout an item to another patron using the staff interface. . Example: checked out 39999000011418 to Mary Burton 9. As the patron in step 2, use the self-checkout to try and checkout this item: ==> Message says: "This item appears to be checked out to another patron, please return it to the desk" . Has Submit and Close buttons . Click the Close button 10. Use the self-checkout to try and checkout an item on hold: . Place a hold for an item for another patron using the staff interface. Example: Placed a record level hold for Programming the Perl DBI (biblionumber = 13) ==> Message says: "This item appears to be reserved for another patron, please return it to the desk" . Has Submit and Close buttons . Click the Close button 11. Use the self checkout to try and checkout an item on hold that is waiting for pickup for a patron (I used koha): . Place a record-level hold for an item using the staff interface (used Perl Better Practices, biblionumber = 19) . Check in an item for the record and confirm the hold (used 39999000008036), should show status as awaiting pickup . Use the self checkout to try and checkout this item to the patron the hold was placed for (39999000008036 and patron koha in this instance) ==> Item should be successfully checked out with message "Item '39999000008036' was checked out", with options to enter another barcode, Submit and Close buttons ==> Click close and check your account > your summary: item checked out should be listed 12. Repeat step 11, but use the self checkout to try and checkout an item that is on hold and waiting for pickup by another patron (I used Mary Burton to place the hold, and koha to check it out): ==> Message says: "Message code 'RESERVE_WAITING' with data '1' Message code 'reswaitingdate' with data '2023-01-13'" . Has Confirm and Close buttons . Confirm button: - checks out item to patron who didn't have the hold waiting (koha) - item shows (in the staff interface) as checked out to koha, and also waiting for pickup (for Mary) 13. Try and checkout and item not for loan: . Update an item for a record so that is not for loan . Try and checkout using the self-checkout ==> message says: "This item is not normally for loan, please select another or ask at the desk" . Has Submit and Close buttons ==> Item does not check out, as expected. 14. Try and checkout an item recorded as Withdrawn: . Update an item for a record so that it is withdrawn . Try and checkout using the self-checkout ==> message says: "This item is marked withdrawn, please select another or ask at the desk" 15. Add a manual charge for the koha patron then try and check out an item. . Add a manual invoice for the koha patron of $20. ==> message says: "Your account is currently in debt by '20'" ==> Does not checkout item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #37 from David Nind <david@davidnind.com> --- Hi Martin. The only wrinkles I found this time were: 1. Step 12 - checkout an item that is waiting for pickup by another patron: was able to checkout the item waiting, even though it wasn't for me. ==> Message says: "Message code 'RESERVE_WAITING' with data '1' Message code 'reswaitingdate' with data '2023-01-13'" . Has Confirm and Close buttons . Confirm button: - checks out item to patron who didn't have the hold waiting (koha) - item shows (in the staff interface) as checked out to koha, and also waiting for pickup (for Mary) 2. Barcodes with a space before it - items aren't found: I recall testing another bug for this, but can't find it. But anyway, this is not specifically related to this bug. I didn't try and use the public API to query for items that are hidden/not visible in the OPAC (not entirely sure how to set this up properly). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 [Bug 32711] Add biblio details to trusted self-checkout modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145620&action=edit Bug 31699: Add 'return' option to opac modal login This patch adds the option to trigger a redirect back to the current context after successful login using modal logins triggered from various places in the OPAC. To make use of this, simply add 'data-return="true"' to the modal trigger link. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145621&action=edit Bug 31699: (follow-up) Protect against unauthorized redirects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145622&action=edit Bug 31699: (follow-up) Protect more against open redirects This change checks that the OPACBaseURL exists, and uses its scheme and authority to rewrite the URL passed through the "return" param. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145280|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145623&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145281|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145624&action=edit Bug 30979: Add public items lookup route This patch adds a /public equivilent to the item listing endpoint. This allows us to search for an item by it's external_id (barcode). Test plan 1. Apply patch 2. Perform a GET on /api/v1/public/items?external_id=some_barcode 3. Confirm that the above enpoint correctly returns items that should be visible in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145282|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145625&action=edit Bug 30979: Public checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/public/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout endpoint at `/public/checkouts` that accepts a POST request with checkout details including item_id and a confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145283|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145626&action=edit Bug 30979: Remove data from publically facing API The availability API was leaking some patron information for certain cases. This bug adds a deny-list to remove the leaked fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145284|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145627&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145285|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145628&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145629&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145630&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145621|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145622|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #49 from David Nind <david@davidnind.com> --- I've run the test plan in comment #36 again. The issue for step 12 mention in comment #37 still applied. Would be happy for this to be treated as a separate bug if required, as it is possibly an edge case. Also, if no user is logged in, I don't get a login prompt when I click on 'Self checkout'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We had a discussion about a trusted self checkout feature this week and the question about checking out items already checked out to another came up. The request was, that it should be possible to do this in a trusted environment. I can imagine it makes sense and it avoids people taking the item anyway, writing a note etc. Maybe it could be handled differently here than in the normal SCO as we assume a higher level of trust or could be made configurable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #51 from Magnus Enger <magnus@libriotech.no> --- Katrin, could you explain a bit more about what you mean by "trusted environment", please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #0)
In some trusted environments libraries would like their users to self-issue without having to use the SCO or SIP checkouts. i.e. once logged in a user should have the ability to check out to themselves much like they already have the option to renew and place holds etc.
Mostly citing Martin :) With this feature you do have to trust the people checking out and checking in, because they could practically do anything, they are probably alone in the rooms of the library. It will work from every computer, from a mobile phone etc. you won't be able to watch them. It will also work from their home computers, they could just check in whatever they had checked out before. --> So if they can access an item that is checked out to someone else, we should maybe only warn, but assume that it's better to track than to forbid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 [Bug 23641] Checkout via camera on device -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #53 from Christopher Brannon <cbrannon@cdalibrary.org> --- Perhaps we should have options to handle different cases. For each case we have an option to check out or ask that the item be brought to a staff member for further action. Maybe also an option to run this feature from a specific IP. I could see this getting abused if a patron runs out of renewals, and (Is self check in a feature? Not sure that it needs to be, but should be able to independently turn that off.) if they can check it in, the check it in and then check it out. If the library gives rights to check out if it is in hand (like sco and staff might allow) then they could have something indefinitely. There definitely needs to be some safeguards if self check in is a thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So, we now have a backported version of this (at 21.11) at one site and it's likely to hit landfall at a few more imminently. I need to write unit tests and get community folks opinions on the API design. Right now it's designed to mimick the behaviour of the normal SCO in terms of blocks and checks and. I think opening it up further should be proposed in their own follow-up bugs so we can get the core feature in sooner. Really great to see people interested in this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23336 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Bug 30979 depends on bug 31699, which changed state. Bug 31699 Summary: Add a generic way to redirect back to the page you were on at login for modal logins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #55 from Alex Buckley <alexbuckley@catalyst.net.nz> --- *** Bug 30444 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33146 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33146 [Bug 33146] Add a public fetch endpoint for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Bug 30979 depends on bug 33146, which changed state. Bug 33146 Summary: Add a public fetch endpoint for items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33146 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |kyle@bywatersolutions.com --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- I've reviewed Martin's rebase and it's looking good! I've reset the status to assigned so Martin can change it back to NSO when the patch set is ready! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/mrenvoiz |https://github.com/PTFS-Eur |e/Koha/-/tree/bug_30979 |ope/koha/tree/bug_30979_reb | |ased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150867&action=edit Bug 30979: Unit tests - Availability endpoint This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150868&action=edit Bug 30979: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145627|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150869&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150870&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145623|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150871&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150872&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145628|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150873&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145629|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150874&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145630|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150875&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150876&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150877&action=edit Bug 32711: Add biblio details to modal This patch adds biblio details to the self-checkout modal. As part of this we add 'biblio' to the x-koha-embed option on the public items endpoint, clone the js-biblio-format include from the staff client adapting it slightly for OPAC use along the way and also import escape_str and escapeHtml from staff to opac too. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150878&action=edit Bug 32711: Add 'public_read_list' appropriately We're exposing biblio (and thus biblioitem) to the public API now and as such we need to explisitely list which fields to include in the response when called on the public api. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150879&action=edit Bug 32711: Fix biblio embeds We need to drop the embed part of the args we pass to biblioitem else we end up with some very strange behaviours on the acquisitions endpoint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150867|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150880&action=edit Bug 30979: Unit tests - Availability endpoint This patch adds unit tests for the new checkout availability endpoint we're going to introduce in this patchset. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150868|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150881&action=edit Bug 30979: Add checkout API's This patch adds API's to allow for a checkout flow using the RESTful API. We add an availability endpoint to check an items current availability status. The endpoint can be found at `/checkouts/availability` and is a GET request that requires item_id and patron_id passed as parameters. We return an availability object that includes blockers, confirms, warnings and a confirmation token to be used for checkout. We also add a corresponding checkout method to the `/checkouts` endpoint. The method accepts a POST request with checkout details including item_id , patron_id and the confirmation token in the body. Future work: We should properly migrate CanBookBeIssued into Koha::* and use that here instead of refering to C4::Circulation. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150869|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150882&action=edit Bug 30979: Fix inconsistent return of AddIssue AddIssue can on occasion create a renewal instead of a fresh issue and in such a case we currently return undefined. We should be consistent and return the existing issue object for the renewal. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150870|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150883&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150871|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150884&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150872|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150885&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150873|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150886&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150874|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150887&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150875|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150888&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150876|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150889&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 [Bug 23336] Add an API endpoint for issuing an item to a patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150967&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150883|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150968&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150884|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150969&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150885|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150970&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150886|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150971&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150887|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150972&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150888|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150973&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150889|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 150974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150974&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/PTFS-Eur | |ope/koha/tree/bug_30979_reb | |ased | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150967|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151254&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150968|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151255&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150969|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151256&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150970|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151257&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150971|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151258&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150972|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151259&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150973|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151260&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150974|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151261&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151254|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151358&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151255|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151359&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151256|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151360&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151257|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151361&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151258|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151362&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151259|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151363&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151260|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151364&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151261|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151365&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. the rebase on 23336 broke something here.. working on a fresh rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151358|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151368&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151359|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151369&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151360|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151370&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151361|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151371&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151362|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151372&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151363|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151373&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151364|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151374&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151365|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151375&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151376&action=edit Bug 30979: (follow-up) Fix public availability 500 When we introduced the logged in user id to the token generation we had the knock on effect of creating a 500 response for unauthenticated availability lookups. This patch resolves the 500, but results in a token that's not useful for the end user. We should consider this in the wider context down the line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151368|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152789&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151369|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152790&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151370|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152791&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151371|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152792&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151372|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152793&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151373|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152794&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151374|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152795&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151375|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152796&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151376|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152797&action=edit Bug 30979: (follow-up) Fix public availability 500 When we introduced the logged in user id to the token generation we had the knock on effect of creating a 500 response for unauthenticated availability lookups. This patch resolves the 500, but results in a token that's not useful for the end user. We should consider this in the wider context down the line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152789|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153459&action=edit Bug 30979: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152790|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153460&action=edit Bug 30979: Add public endpoints This patch expands the checkouts endpoints to allow for a public workflow. We add the availability endpoint under `/public/checkouts/availability` and restrict the information we send back to only those fields a public user should be allowed to see. We also add a new checkout endpoint at `/patrons/{patron_id}/checkouts` that allows for users to checkout to themselves and accepts the same POST request with checkout details including item_id and a confirmation token in the body that the staff client endpoints accept. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152791|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153461&action=edit Bug 30979: Add 'OpacTrustedCheckout' preference This patch adds a new 'OpacTrustedCheckout' system preference to govern whether the library allows opac users to check out items to themselves from their OPAC login. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152792|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153462&action=edit Bug 30979: Limit public checkout endpoint using preference The public api endpoint for self-checkout should only be enabled in the case where the OpacTrustedSelfCheckout option is enabled. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152793|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153463&action=edit Bug 30979: Add checkout modal to the OPAC This patch adds a new self checkout modal to the OPAC when OpacTrustedCheckout is enabled and a user is logged in. The new modal allows an end user to scan an item barcode to checkout. We check for item existance and availability and then check the item out after any confirmations have been displayed. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152794|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153464&action=edit Bug 30979: Always show self-checkout when preference enabled This patch updates the display logic such that if the truested self-checkout option is enabled we always show the checkout button and prompt a login when no user is found. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152795|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153465&action=edit Bug 30979: Redirect to checkout summary This is a temporary solution whilst we wait for the biblio api endpoints so we may include more biblio details in the checkout modal itself. Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152796|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153466&action=edit Bug 30979: Add modal trigger to shibboleth target url Signed-off-by: Silvia Meakins <smeakins@eso.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152797|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153467&action=edit Bug 30979: (follow-up) Fix public availability 500 When we introduced the logged in user id to the token generation we had the knock on effect of creating a 500 response for unauthenticated availability lookups. This patch resolves the 500, but results in a token that's not useful for the end user. We should consider this in the wider context down the line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just another rebase to make sure it still applies clean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #133 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #134 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 153500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153500&action=edit Bug 30979: (QA follow-up) Add missing docs on error codes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #135 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 153501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153501&action=edit Bug 30979: (QA follow-up) Tidy things Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #136 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 153502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153502&action=edit Bug 30979: Fix regression This patch fixes a regression introduced by the 'Fix public availability 500' follow-up. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/checkouts.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Tests are useful! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #137 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 153503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153503&action=edit Bug 30979: Fix xt/api.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34287 [Bug 34287] Patron's should not be able to ask for checkoutability for different patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting Severity|enhancement |new feature --- Comment #138 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- New feature, no backport for 23.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds a new release notes| |`OpacTrustedSelfCheckout` | |system preference. When | |enabled, OPAC users will | |see a new checkout option | |in the header of the page | |when logged in. This option | |displays a modal where they | |can scan barcodes to | |perform a self checkout. | | | |**Sponsored by** *European | |Southern Observatory* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds a new |This new feature adds a new release notes|`OpacTrustedSelfCheckout` |`OpacTrustedCheckout` |system preference. When |system preference. When |enabled, OPAC users will |enabled, OPAC users will |see a new checkout option |see a new checkout option |in the header of the page |in the header of the page |when logged in. This option |when logged in. This option |displays a modal where they |displays a modal where they |can scan barcodes to |can scan barcodes to |perform a self checkout. |perform a self checkout. | | |**Sponsored by** *European |**Sponsored by** *European |Southern Observatory* |Southern Observatory* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35481 [Bug 35481] Ignore whitespace when entering or scanning barcodes in trusted web checkout modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35482 [Bug 35482] Trusted self check modal too small for translations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36415 [Bug 36415] Allow limiting 'TrustedSelfCheckout' to an IP address range -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36615 [Bug 36615] Terminology: use 'on hold' instead of 'reserved' in OPAC self checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/867 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37291 [Bug 37291] Update OpacTrustedCheckout preference to allow limiting to certain library branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 [Bug 37076] Incorrect needsconfirmation code RESERVED_WAITING -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Bug 30979 depends on bug 23336, which changed state. Bug 23336 Summary: Add an API endpoint for checking an item out to a patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org