[Bug 29289] New: 'Show fines to guarantor' should have it's own class on staff patron detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Bug ID: 29289 Summary: 'Show fines to guarantor' should have it's own class on staff patron detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The "Show fines to guarantor" on the details tab in the patron account on the staff side should have it's own id for easy customization as the entry for showing checkouts already has. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #1 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Show fines to guarantor' |'Show fines to guarantor' |should have it's own class |should have its own id on |on staff patron detail page |patron detail page Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127493&action=edit Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127493|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 127494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127494&action=edit Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- <li id="patron-privacyguarantor"> <li id="patron-privacy_guarantor_fines"> That's inconsistent... Not blocker however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127494|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128467&action=edit Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org