[Bug 32115] New: Add ID to check-out default help message dialog to allow customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Bug ID: 32115 Summary: Add ID to check-out default help message dialog to allow customization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: m+koha@mpan.ch Reporter: m+koha@mpan.ch QA Contact: testopia@bugs.koha-community.org We want to customize the default help message on the Self checkout page, as our library doesn't have bar codes and therefore doesn't have scanning. We only have a number that users input when using self checkout. The help message confused our users. This doesn't seem to be something that many libraries will have. Therefore as an easy solution, I propose to create a patch that adds a div with an id around the default help message. Then we can add our own help content in "SCOMainUserBlock" and hide the default message with CSS in "SCOUserCSS". Otherwise I could also see there being a new flag that specifies whether a library has scanning or not and changing the text based on that. That would require lots of translation effort that doesn't seem worth it to me. I will attach a patch to this with my proposed solution but I am also open to implementing other solutions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #1 from m+koha@mpan.ch --- Created attachment 143299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143299&action=edit Proposed patch to add div with id to allow hiding it and customize with SCOMainUserBlock. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 m+koha@mpan.ch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 m+koha@mpan.ch changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m+koha@mpan.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144089&action=edit Bug 32115: Add ID to check-out default help message dialog to allow customization This adds a div with the id attribute selfcheckdefaulthelpmessage to the first paragraph of the web based self check help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify by looking at the source code, that the first paragraph starting with "If this is your first time..." now has an id. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mona, I believe this has been your first patch for Koha? Welcome! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #4 from m+koha@mpan.ch --- Yes, this is my first patch as I only recently started to work at a library :) What are the next steps to get the patch merged? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is signed-off now, which means you passed the first round of testing. Now it' s waiting for the QA team to have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144089|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144497&action=edit Bug 32115: Add ID to check-out default help message dialog to allow customization This adds a div with the id attribute selfcheckdefaulthelpmessage to the first paragraph of the web based self check help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify by looking at the source code, that the first paragraph starting with "If this is your first time..." now has an id. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Welcome aboard Mona, The patch is nice and simple and works well.. I'd love to see this block moved to a News block as that way it becomes easier for staff to change in the staff client and have translations working.. but that can be another bug. No regressions found and the QA script is happy. Passing QA. Congratulations on your first patch, now it's over to the Release Manager to get it pushed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Strictly this one is an enhancement, but as it's so unobtrusive I'm opting to backport it.. welcome to the stables Mona :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.01 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- I tend to agree with Martin. Adding a class/ID is unobtrusive and helpful. Opting to backport, welcome to the oldstables Mona. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01 |23.05.00,22.11.01,22.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01,22.05.09 |23.05.00,22.11.01,22.05.09, released in| |21.11.16 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org