[Bug 27792] New: Improve jEditable configuration for point of sale fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Bug ID: 27792 Summary: Improve jEditable configuration for point of sale fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org We can leverage some jEditable configuration options to improve the behavior of the inline-editable fields in the Point of Sale interface: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry Unfortunately jEditable doesn't seem to have an option to add an "inputmode" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117306&action=edit Bug 27792: Improve jEditable configuration for point of sale fields This patch alters the configuration of the "cost" and "quantity" editable fields in the "This sale" table on the Point of Sale page: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry To test you must have EnablePointOfSale and UseCashRegisters enabled and configured. - Apply the patch and go to the Point of Sale page. - Add some items for purchase. - In the "This sale" table, click the values in the "cost" and "quantity" columns and try editing their values. - The form field which appears should not fill the width of the table column. - The fields should enforce the correct input: Currency for the "cost" column, digits for the "quantity" column. - The fields should update when you click out of them and the correct values should appear in the "Collect payment" area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117306|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117324&action=edit Bug 27792: Improve jEditable configuration for point of sale fields This patch alters the configuration of the "cost" and "quantity" editable fields in the "This sale" table on the Point of Sale page: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry To test you must have EnablePointOfSale and UseCashRegisters enabled and configured. - Apply the patch and go to the Point of Sale page. - Add some items for purchase. - In the "This sale" table, click the values in the "cost" and "quantity" columns and try editing their values. - The form field which appears should not fill the width of the table column. - The fields should enforce the correct input: Currency for the "cost" column, digits for the "quantity" column. - The fields should update when you click out of them and the correct values should appear in the "Collect payment" area. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117325&action=edit Bug 27792: (follow-up) Double escape the escape The JSON patturn wasn't getting interpreted correctly for me.. the `\` characters needed escaping with a second `\`. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117324|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117412&action=edit Bug 27792: Improve jEditable configuration for point of sale fields This patch alters the configuration of the "cost" and "quantity" editable fields in the "This sale" table on the Point of Sale page: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry To test you must have EnablePointOfSale and UseCashRegisters enabled and configured. - Apply the patch and go to the Point of Sale page. - Add some items for purchase. - In the "This sale" table, click the values in the "cost" and "quantity" columns and try editing their values. - The form field which appears should not fill the width of the table column. - The fields should enforce the correct input: Currency for the "cost" column, digits for the "quantity" column. - The fields should update when you click out of them and the correct values should appear in the "Collect payment" area. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117325|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117413&action=edit Bug 27792: (follow-up) Double escape the escape The JSON patturn wasn't getting interpreted correctly for me.. the `\` characters needed escaping with a second `\`. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch improves release notes| |interactions with | |inline-editable fields in | |the Point of Sale interface | |to prevent jumpy table | |re-draws and to enforce the | |required currenty/number | |input types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.04 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backporting to 20.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org