http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21255&action=edit Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #3 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21255|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21456&action=edit [SIGNED-OFF] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21456|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21827&action=edit [PASSED QA] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only. Passes all tests and QA script. Tested: - Confirmed that changing the pickup location is not possible in master without the modify_holds_priority permission - Confirmed that the patch fixes the problem - pickup location can now be changed with and without the permission - Pickup location can still not be changed, when IndependentBranches is activated -- You are receiving this mail because: You are watching all bug changes.