[Bug 44065] New: Alternate address with AddressFormat "de" shows no space between postcode and city
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 Bug ID: 44065 Summary: Alternate address with AddressFormat "de" shows no space between postcode and city Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- With AddressFormat set to "German style", the "Alternate address" box on the staff patron details page shows the postcode and city, and the street and house number, without a space between them: Hauptstraße12 12345Musterstadt The main address is shown correctly. To reproduce: 1. Set AddressFormat to "German style" 2. Edit a patron, under "Alternate address" enter Address: Hauptstraße, Street number: 12, ZIP/Postal code: 12345, City: Musterstadt 3. Go to the patron's details page 4. The "Alternate address" box shows "Hauptstraße12" and "12345Musterstadt" The codebase tidy (Bug 38664) joined the address parts of the "de" block in member-display-alt-address-style.inc onto single lines, dropping the spaces between them. Bug 40319 fixed the same problem in member-display-address-style.inc, but not in the alternate address include. The "fr" and "us" blocks are fine. Affects 25.05.x, 25.11.x and main. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40319, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38664 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 211461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211461&action=edit Bug 44065: Fix spacing in alternate address display - The "de" block of member-display-alt-address-style.inc has its address parts on single lines with no whitespace between them, so the staff patron details page shows "Hauptstraße12" and "12345Musterstadt" - Put each part on its own line, as in the "fr" block, so they are separated by a space - Same fix as Bug 40319 for member-display-address-style.inc Test plan: 1. Set the AddressFormat system preference to "German style" 2. Edit a patron, under "Alternate address" enter: Address: Hauptstraße, Street number: 12, ZIP/Postal code: 12345, City: Musterstadt 3. Go to the patron's details page 4. Without this patch, the "Alternate address" box shows "Hauptstraße12" and "12345Musterstadt" 5. Apply the patch and reload: it shows "Hauptstraße 12" and "12345 Musterstadt" 6. Set AddressFormat to "French style" and "US style": the alternate address is unchanged Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 211492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211492&action=edit Bug 44065: Fix spacing in alternate address display - The "de" block of member-display-alt-address-style.inc has its address parts on single lines with no whitespace between them, so the staff patron details page shows "Hauptstraße12" and "12345Musterstadt" - Put each part on its own line, as in the "fr" block, so they are separated by a space - Same fix as Bug 40319 for member-display-address-style.inc Test plan: 1. Set the AddressFormat system preference to "German style" 2. Edit a patron, under "Alternate address" enter: Address: Hauptstraße, Street number: 12, ZIP/Postal code: 12345, City: Musterstadt 3. Go to the patron's details page 4. Without this patch, the "Alternate address" box shows "Hauptstraße12" and "12345Musterstadt" 5. Apply the patch and reload: it shows "Hauptstraße 12" and "12345 Musterstadt" 6. Set AddressFormat to "French style" and "US style": the alternate address is unchanged Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44065 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 211599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211599&action=edit Bug 44065: Fix spacing in alternate address display - The "de" block of member-display-alt-address-style.inc has its address parts on single lines with no whitespace between them, so the staff patron details page shows "Hauptstraße12" and "12345Musterstadt" - Put each part on its own line, as in the "fr" block, so they are separated by a space - Same fix as Bug 40319 for member-display-address-style.inc Test plan: 1. Set the AddressFormat system preference to "German style" 2. Edit a patron, under "Alternate address" enter: Address: Hauptstraße, Street number: 12, ZIP/Postal code: 12345, City: Musterstadt 3. Go to the patron's details page 4. Without this patch, the "Alternate address" box shows "Hauptstraße12" and "12345Musterstadt" 5. Apply the patch and reload: it shows "Hauptstraße 12" and "12345 Musterstadt" 6. Set AddressFormat to "French style" and "US style": the alternate address is unchanged Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org