[Bug 18214] New: Cannot edit list permissions of a private list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Bug ID: 18214 Summary: Cannot edit list permissions of a private list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Trivial change in opac-shelves template. No need to change staff side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60821&action=edit Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60821|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 60822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60822&action=edit Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10865 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a Koha::VirtualShelf->is_shared method, should not we use it to know if the permissions must be displayed or not? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
There is a Koha::VirtualShelf->is_shared method, should not we use it to know if the permissions must be displayed or not?
You dont need the check, opac-shelves will already say: You do not have permission to update this list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
There is a Koha::VirtualShelf->is_shared method, should not we use it to know if the permissions must be displayed or not?
And it may have been shared. Or it was a public list. So the list may contain items from other people.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18228 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Temporarily blocking this one in favor of bug 18228. That bug includes this change too, but simplifies things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We just ran into this: If OpacAllowPublicListCreation is turned off, you can't allow users to add to your shared list. This renders the sharing a bit useless :( It's especially odd since the system preference OpacAllowSharingPrivateLists talks about sharing private lists and I would expect that to enable the permission options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #7)
We just ran into this:
If OpacAllowPublicListCreation is turned off, you can't allow users to add to your shared list. This renders the sharing a bit useless :(
It's especially odd since the system preference OpacAllowSharingPrivateLists talks about sharing private lists and I would expect that to enable the permission options.
This problem is definitely solved with bug 18228. The trivial change on this report is incorporated in the larger solution on that report. *** This bug has been marked as a duplicate of bug 18228 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand, but not sure if the bigger solution can be backported as it also changes behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60822|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #9)
I understand, but not sure if the bigger solution can be backported as it also changes behaviour.
Reopening this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
There is a Koha::VirtualShelf->is_shared method, should not we use it to know if the permissions must be displayed or not?
On second thought, I will add a check for shared or public list here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64504&action=edit Bug 18214: Add check for shared or public list Following the idea behind bug 10865, we are only showing the permissions when the list is shared or public. Adding a simple test in opac-shelves here. Note 1: Since the owner can always add or delete entries, the permissions will not be relevant anymore for a strictly private list. Note 2: Staff view always shows the permissions. This could have been changed here too, but that change is far less urgent (bug 10865 did not touch staff view and bug 18228 will rearrange permissions anyway). Test plan: [1] Verify on OPAC that you see the permissions for a private list with shares or a public list. And you do not see them for a private list without shares. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #9)
I understand, but not sure if the bigger solution can be backported as it also changes behaviour.
The two current patches should be easy to backport. I will rebase 18228/834. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving these trivial patches to the RM queue now. They had enough attention now imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 [Bug 18228] Make list permissions easier to use/understand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org