[Bug 34406] New: Inconsistencies in Identity providers/domains page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Bug ID: 34406 Summary: Inconsistencies in Identity providers/domains page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Identity providers page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Edit identity provider' to "Modify identity provider 'code'" or "Modify identity provider 'description' (code)" - Add a level for "Email domains for 'code'" or "Email domains for 'description' (code)" - Change 'Edit identity provider domain' to "Modify email domain 'domain'" Breadcrumb - Change 'Edit identity provider' to "Modify identity provider 'code'" or "Modify identity provider 'description' (code)" - In Domains, put code in single quotes (or descriptions in single quotes and code in parentheses) - Change Domains to Email domains - Change 'Edit domain' to "Modify email domain 'domain'" Page header - Change 'Edit identity provider' to "Modify identity provider 'code'" or "Modify identity provider 'description' (code)" - Change 'Identity provider email domains' to "Email domains for 'code'" or "Email domains for 'description' (code)" - Change 'New email domain' to "New email domain for 'code'" or "New email domain for 'description' (code)" - Change 'Edit identity provider domain' to "Modify email domain 'domain'" There is no special page when deleting an email domain, only a modal. There is no special page when deleting an identity provider, only a modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156622&action=edit Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the templates for identity providers and identity provider domains, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> Identity providers - New identity provider - Edit identity provider - Confirm deletion of identity provider - Manage domains - New domain - Edit domain - Confirm deletion of domain -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156622|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 158021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158021&action=edit Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the templates for identity providers and identity provider domains, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> Identity providers - New identity provider - Edit identity provider - Confirm deletion of identity provider - Manage domains - New domain - Edit domain - Confirm deletion of domain Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at how the rest of the patch changes things, should this not read "Identify provider domains for ..."? + <span>[% tx("Domains for '{identity_provider_code}'", {identity_provider_code = identity_provider_code}) | html %]</span> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158021|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158221&action=edit Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the templates for identity providers and identity provider domains, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> Identity providers - New identity provider - Edit identity provider - Confirm deletion of identity provider - Manage domains - New domain - Edit domain - Confirm deletion of domain Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158222&action=edit Bug 34406: (QA follow-up) Add another "Identity provier" to "domains" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34406 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not to backport to avoid translation work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org