[Bug 22531] New: Allow for multiple requests to partners and display partners in audit log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Bug ID: 22531 Summary: Allow for multiple requests to partners and display partners in audit log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Target Milestone: --- Currently, when an ILL request is sent to partners it is not possible to send to further partners, should the first partner not be able to fulfil the request. A better approach would be to allow the "Place request with partners" option to be selected even when this action has already taken place. This will allow the user to try multiple partners subsequently. As such, we should log which partners a request has been sent to and this information should be displayed in the "Display request log" functionality added in Bug 20750 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86723&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86744&action=edit Bug 22531: Add unit tests Add tests for new and modified methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: - Ensure you have at least two "partners" set up. These are patrons in the category defined in <interlibrary_loans> -> <partner_code> in koha-conf.xml, the patrons must also have a primary email address defined. - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: (ignore the plan in comment #3) - Ensure you have at least two "partners" set up. These are patrons in the category defined in <interlibrary_loans> -> <partner_code> in koha-conf.xml, the patrons must also have a primary email address defined. - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - Go to the "Manage ILL request" screen => TEST: Observe that the request "Status" is "Requested from partners : first_partner_email_address_here" => TEST: Observe that the first_partner_email_address links to the appropriate patron screen - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) => TEST: Observe that the email addresses displayed link to the appropriate patron page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Bug 22531 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |joonas.kylmala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I had a go at rebasing this one.. and it didn't appear too bad.. but my rebased set had all the unit tests failing. Going to ask Andrew for a rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86723|0 |1 is obsolete| | --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 118843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118843&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86744|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 118844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118844&action=edit Bug 22531: Add unit tests Add tests for new and modified methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Revised test plan: - Ensure you have at least two "partners" set up. These are patrons in the category defined in <interlibrary_loans> -> <partner_code> in koha-conf.xml, the patrons must also have a primary email address defined. - Ensure the ILLLOG syspref is turned on - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - Go to the "Manage ILL request" screen => TEST: Observe that the request "Status" is "Requested from partners : first_partner_email_address_here" => TEST: Observe that the first_partner_email_address links to the appropriate patron screen - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) => TEST: Observe that the email addresses displayed link to the appropriate patron page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118843|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122643&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118844|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122644&action=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-ff-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Signed off by Barry Cannon on behalf of the Institutes of Technology, whom he supports. Testing was undertaken at multiple sites and is now in live use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Applying: Bug 22531: Add logging & display of req partners Applying: Bug 22531: Add unit tests error: sha1 information is lacking or useless (Koha/Illrequest/Logger.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22531: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122643|0 |1 is obsolete| | --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 124979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124979&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122644|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 124980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124980&action=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I am having a bit of trouble with this one: prove t/db_dependent/Illrequests.t t/db_dependent/Illrequests.t .. 3/13 # Failed test 'new node + core_status_graph = bigger status graph' # at t/db_dependent/Illrequests.t line 272. # Compared array length of $data->{"GENREQ"}{"next_actions"} # got : array with 3 element(s) # expect : array with 2 element(s) # { # 'CANCREQ' => { # 'id' => 'CANCREQ', # 'method' => 0, # 'name' => 'Cancellation requested', # 'next_actions' => [ # 'KILL', # 'REQ' # ], # 'prev_actions' => [ # 'NEW' # ], # 'ui_method_icon' => 0, # 'ui_method_name' => 0 # }, # 'CHK' => { # 'id' => 'CHK', # 'method' => 'check_out', # 'name' => 'Checked out', # 'needs_all' => [ # sub { "DUMMY" } # ], # 'needs_perms' => [ # 'user_circulate_circulate_remaining_permissions' # ], # 'needs_prefs' => [ # 'CirculateILL' # ], # 'next_actions' => [], # 'prev_actions' => [ # 'REQ', # 'GENREQ', # 'COMP' # ], # 'ui_method_icon' => 'fa-upload', # 'ui_method_name' => 'Check out' # }, # 'COMP' => { # 'id' => 'COMP', # 'method' => 'mark_completed', # 'name' => 'Completed', # 'next_actions' => [ # 'CHK' # ], # 'prev_actions' => [ # 'REQ' # ], # 'ui_method_icon' => 'fa-check', # 'ui_method_name' => 'Mark completed' # }, # 'GENREQ' => { # 'id' => 'GENREQ', # 'method' => 'generic_confirm', # 'name' => 'Requested from partners', # 'next_actions' => [ # 'COMP', # 'CHK', # 'GENREQ' # ], # 'prev_actions' => [ # 'NEW', # 'REQREV', # 'GENREQ' # ], # 'ui_method_icon' => 'fa-send-o', # 'ui_method_name' => 'Place request with partners' # }, # 'KILL' => { # 'id' => 'KILL', # 'method' => 'delete', # 'name' => 0, # 'next_actions' => [], # 'prev_actions' => [ # 'QUEUED', # 'REQREV', # 'NEW', # 'CANCREQ' # ], # 'ui_method_icon' => 'fa-trash', # 'ui_method_name' => 'Delete request' # }, # 'NEW' => { # 'id' => 'NEW', # 'method' => 'create', # 'name' => 'New request', # 'next_actions' => [ # 'REQ', # 'GENREQ', # 'KILL' # ], # 'prev_actions' => [], # 'ui_method_icon' => 'fa-plus', # 'ui_method_name' => 'New request' # }, # 'QUEUED' => { # 'id' => 'QUEUED', # 'method' => 0, # 'name' => 'Queued request', # 'next_actions' => [ # 'REQ', # 'KILL' # ], # 'prev_actions' => [], # 'ui_method_icon' => 0, # 'ui_method_name' => 0 # }, # 'REQ' => { # 'id' => 'REQ', # 'method' => 'confirm', # 'name' => 'Requested', # 'next_actions' => [ # 'REQREV', # 'COMP', # 'CHK' # ], # 'prev_actions' => [ # 'NEW', # 'REQREV', # 'QUEUED', # 'CANCREQ' # ], # 'ui_method_icon' => 'fa-check', # 'ui_method_name' => 'Confirm request' # }, # 'REQREV' => { # 'id' => 'REQREV', # 'method' => 'cancel', # 'name' => 'Request reverted', # 'next_actions' => [ # 'REQ', # 'GENREQ', # 'KILL' # ], # 'prev_actions' => [ # 'REQ' # ], # 'ui_method_icon' => 'fa-times', # 'ui_method_name' => 'Revert Request' # }, # 'RET' => { # 'id' => 'RET', # 'method' => 'check_in', # 'name' => 'Returned to library', # 'next_actions' => [ # 'COMP' # ], # 'prev_actions' => [ # 'CHK' # ], # 'ui_method_icon' => 'fa-download', # 'ui_method_name' => 'Check in' # }, # 'TEST' => { # 'id' => 'TEST', # 'next_actions' => [], # 'prev_actions' => [] # } # } # Looks like you failed 1 test of 5. t/db_dependent/Illrequests.t .. 5/13 # Failed test 'Status Graph tests' # at t/db_dependent/Illrequests.t line 380. t/db_dependent/Illrequests.t .. 11/13 # Looks like you planned 3 tests but ran 5. # Failed test 'Custom statuses' # at t/db_dependent/Illrequests.t line 1343. t/db_dependent/Illrequests.t .. 13/13 # Looks like you failed 2 tests of 13. t/db_dependent/Illrequests.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/13 subtests Test Summary Report ------------------- t/db_dependent/Illrequests.t (Wstat: 512 Tests: 13 Failed: 2) Failed tests: 5, 12 Non-zero exit status: 2 There are also some minor QA fails (tab characters and missing TT filters). I would have fixed those, but holding off now as the tests might need a little work anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124979|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131234&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124980|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131235&action=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131236&action=edit Bug 22531: (QA follow-up) Fix filter and tab issues Correction to template filters and replace tabs with spaces in code to pass the QA script. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131237&action=edit Bug 22531: (QA follow-up) Fix Unit Tests This patch series adds the ability to generate a partners request multiple times from the same ILL request. It does this be adding the 'GENREQ' action to both 'prev_actions' and 'next_actions' in the 'GENREQ' status segment of the status graph. This QA followup updates the status graph tests to reflect this change. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131234|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133708&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131235|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133709&action=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131236|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133710&action=edit Bug 22531: (QA follow-up) Fix filter and tab issues Correction to template filters and replace tabs with spaces in code to pass the QA script. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131237|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133711&action=edit Bug 22531: (QA follow-up) Fix Unit Tests This patch series adds the ability to generate a partners request multiple times from the same ILL request. It does this be adding the 'GENREQ' action to both 'prev_actions' and 'next_actions' in the 'GENREQ' status segment of the status graph. This QA followup updates the status graph tests to reflect this change. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I like the idea. Isn't this a bit hacky? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #24)
I like the idea. Isn't this a bit hacky?
Possibly, as I noted in the patch, I wasn't 100% happy with the solution. I can't remember any of the thought processes involved when I did it, it was written over three years ago, but I'm sure the decisions I made were made for good reasons. I'm not inclined to revisit it now, it has been in use by multiple customers over the past three years with no issues. It would be really nice to see it finally merged after all this time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. Doesn't seem to apply after I pushed 30484 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This was marked rel_22_11_candidate, but currently has no assignee. Martin, since it sounds like it was needed for some of your customers, do you plan to move forward with it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133708|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145726&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145726|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145727&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Sponsored-by: UKHSA Signed-ff-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133709|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145728&action=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133710|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145729&action=edit Bug 22531: (QA follow-up) Fix filter and tab issues Correction to template filters and replace tabs with spaces in code to pass the QA script. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133711|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145730&action=edit Bug 22531: (QA follow-up) Fix Unit Tests This patch series adds the ability to generate a partners request multiple times from the same ILL request. It does this be adding the 'GENREQ' action to both 'prev_actions' and 'next_actions' in the 'GENREQ' status segment of the status graph. This QA followup updates the status graph tests to reflect this change. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32737 [Bug 32737] Don't allow placing multiple ILL requests to same partner -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |pedro.amorim@ptfs-europe.co |.com |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Reading through the code here, my best guess is that many decisions were made in the interest of preserving functionality of existing backends, which I think can be fine, but a few things I would like to see comments, maybe FIXMEs for: 1 - Accepting either a hash or a scalar seems a bit odd, at leats an explanation would help - probably a FIXME 2 - Retrieving ILL partner patrons using a string of emails seems possibly dangerous. I imagine past logs contain only these. If going forward we could use borrowernumbers or something else, that would be ideal. If that would break existing backends an explanation would be nice 3 - Some function names and variables could be made clearer, i.e.: [% FOREACH add IN log.info.additional.partner_email_previous.split('; ') %] add could be 'additional_borrower' Koha::Illrequest::Logger->logged_requested_partners($log); maybe 'return_requested_partners'? the current seems unclear I think with some clarity and cleanup this one can move forward -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23604 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38719 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org