[Bug 37959] New: Item circulation alerts table appears to be broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Bug ID: 37959 Summary: Item circulation alerts table appears to be broken Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To replicate: 1. Click on a cell in the table. The cell changes to save "Saving..." and then appears to become stuck. Nothing ever happens. Refreshing the page returns to the table to its original state. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Severity|enhancement |major Depends on| |36192 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Well, one thing happens when you have the browser console open: POST /cgi-bin/koha/admin/item_circulation_alerts.pl returns a 403, since the ajax request doesn't include the csrf_token. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171699&action=edit Bug 37979: Toggling Item circulation alerts table cells needs to send csrf_token When you click on a cell in the Item circulation alerts table, the page sends a POST to /cgi-bin/koha/admin/item_circulation_alerts.pl without including a csrf_token, which gets back a 403 error because that's sketchy behavior. It needs to include the token. Test plan: 1. Administration - Item circulation alerts 2. Open the browser devtools to the console 3. Click on any green table cell 4. It should have turned red, but instead your console turned red with a 403 5. Apply patch, reload 6. Click on any green table cell, it will turn red Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171699|0 |1 is obsolete| | --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 171701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171701&action=edit Bug 37979: Toggling Item circulation alerts table cells needs to send csrf_token When you click on a cell in the Item circulation alerts table, the page sends a POST to /cgi-bin/koha/admin/item_circulation_alerts.pl without including a csrf_token, which gets back a 403 error because that's sketchy behavior. It needs to include the token. Test plan: 1. Administration - Item circulation alerts 2. Open the browser devtools to the console 3. Click on any green table cell 4. It should have turned red, but instead your console turned red with a 403 5. Apply patch, reload 6. Click on any green table cell, it will turn red Sponsored-by: Chetco Community Public Library https://bugs.koha-community.org/show_bug.cgi?id=37959 Signed-off-by: Jan Kissig <jkissig@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171701|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 171821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171821&action=edit Bug 37979: Toggling Item circulation alerts table cells needs to send csrf_token When you click on a cell in the Item circulation alerts table, the page sends a POST to /cgi-bin/koha/admin/item_circulation_alerts.pl without including a csrf_token, which gets back a 403 error because that's sketchy behavior. It needs to include the token. Test plan: 1. Administration - Item circulation alerts 2. Open the browser devtools to the console 3. Click on any green table cell 4. It should have turned red, but instead your console turned red with a 403 5. Apply patch, reload 6. Click on any green table cell, it will turn red Sponsored-by: Chetco Community Public Library Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Katrin has pushed this, but the bug number in the commit doesn't correspond to the bug number here so it didn't get closed.. Closing on her behalf now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize (ashimema) from comment #6)
Thanks for all the hard work!
Pushed to main for the next 24.11.00 release as RM Assistant
Thanks for noticing, I will keep a note for checking in the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- I can't find the correct commit in main to cherry-pick: kohadev-koha@kohadevbox:koha(rmain2405)$ git log --pretty=oneline main | grep '37959' 000668a6fb1a7d6e0b58785a5fc827e3155b27bb Bug 37959: Correct bug number mistake. Going to just git bz apply this one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Version(s)|24.11.00 |24.11.00,24.05.05 released in| | Status|Pushed to main |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- It was https://git.koha-community.org/Koha-community/Koha/commit/66eabead5f9a2041c8... I'll try to stop thinking I can type bug numbers in commits, and only copy-paste them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There was a mistake in the bug number in the attached patch file (might want to fix before you push): https://git.koha-community.org/Koha-community/Koha/commits/branch/main/search?q=37979&all= -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37979 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37959 Bug 37959 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org