[Bug 36008] New: SendAlerts should use notice_email_address instead of email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Bug ID: 36008 Summary: SendAlerts should use notice_email_address instead of email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org C4::Letters::SendAlerts() uses $patron->email instead of $patron->notice_email_address -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33223 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Still relevant. Should just be a one line change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 177332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177332&action=edit Bug 36008: Use notice_email_address instead of email for SendAlerts issue type This change makes Koha use "notice_email_address" instead of "email" for SendAlerts with a type of "issue". This brings SendAlerts more in line with the rest of Koha Test plan: 0. Apply the patch 1. Create a subscription - Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl - Click "New subscription" and follow the prompts / fill out required fields - On the first screen, ensure "Patron notification" says "New serial issue" (You can edit this after creating the subscription if necessary) 2. Click "subscribers" next to "Patron notification: SERIAL_ALERT" 3. Log into the OPAC, go to the bib record for that subscription, click "Subscriptions", and click "Subscribe to email notification on new issues" and click "Yes" on the subsequent screen 4. Edit your patron record and make sure you have an email in "Secondary email" and not "Primary email" 5. Set up a SMTP server for your Koha or some other email delivery mechanism 6. Go to the "Serial collection" for your subscription e.g. http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl?subscriptio... 7. Click "Receive" 8. Mark the serial as "Arrived" 9. Click "Save" 10. Note that you receive an email using your Koha user's "Secondary Email" address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177332|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177336&action=edit Bug 36008: Use notice_email_address instead of email for SendAlerts issue type This change makes Koha use "notice_email_address" instead of "email" for SendAlerts with a type of "issue". This brings SendAlerts more in line with the rest of Koha Test plan: 0. Apply the patch 1. Create a subscription - Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl - Click "New subscription" and follow the prompts / fill out required fields - On the first screen, ensure "Patron notification" says "New serial issue" (You can edit this after creating the subscription if necessary) 2. Click "subscribers" next to "Patron notification: SERIAL_ALERT" 3. Log into the OPAC, go to the bib record for that subscription, click "Subscriptions", and click "Subscribe to email notification on new issues" and click "Yes" on the subsequent screen 4. Edit your patron record and make sure you have an email in "Secondary email" and not "Primary email" 5. Set up a SMTP server for your Koha or some other email delivery mechanism 6. Go to the "Serial collection" for your subscription e.g. http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl?subscriptio... 7. Click "Receive" 8. Mark the serial as "Arrived" 9. Click "Save" 10. Note that you receive an email using your Koha user's "Secondary Email" address Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Simple clear fix, qa scripts happy, code is clear. Tested and working as expected Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org