[Bug 9052] New: YUI assets installed in the wrong place by packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Priority: P5 - low Change sponsored?: --- Bug ID: 9052 CC: robin@catalyst.net.nz Assignee: koha-bugs@lists.koha-community.org Summary: YUI assets installed in the wrong place by packages Severity: blocker Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Packaging Product: Koha Even though YUI has been moved to opac-tmpl/lib/yui, the packages were installing some of the CSS assets to opac-tmpl/prog/en/yui -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Some more details: The problem is that these two files are not where they are supposed to be: /opac-tmpl/lib/yui/reset-fonts-grids.css /opac-tmpl/lib/yui/skin.css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13720&action=edit Bug 9052: 2 yui files installed in the wrong place by the packages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |chris@bigballofwax.co.nz Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 vimal kumar <vimal0212@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212@gmail.com --- Comment #3 from vimal kumar <vimal0212@gmail.com> --- (In reply to comment #1)
Some more details:
The problem is that these two files are not where they are supposed to be:
/opac-tmpl/lib/yui/reset-fonts-grids.css /opac-tmpl/lib/yui/skin.css
Please guide me, which files I have to move to which location for proper working? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Doug Dearden <dearden@sarsf.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dearden@sarsf.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mjr@software.coop --- Comment #4 from MJ Ray (software.coop) <mjr@software.coop> --- rangi reports in IRC that the patch doesn't work. Moving back to in discussion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #5 from MJ Ray (software.coop) <mjr@software.coop> --- This is a very dirty (messing in /usr/share is not good if you are not the package manager) fix for it: sudo cp -al /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css/{reset-fonts-grids,skin}.css lib/yui/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #6 from MJ Ray (software.coop) <mjr@software.coop> --- I think Bug 8623 was what exposed this bug. Why aren't we depending on Package libjs-yui anyway? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> --- We are linking in the system yui libraries, however Koha isn't referencing them correctly (e.g. skin.css and reset-fonts-grids.css aren't in the same directory: robin@debmaker32:/usr/share/koha/opac/htdocs$ find -L -name skin.css -or -name reset-fonts-grids.css ./opac-tmpl/lib/yui/assets/skins/sam/skin.css ./opac-tmpl/lib/yui/reset-fonts-grids/reset-fonts-grids.css ./opac-tmpl/prog/en/css/skin.css ./opac-tmpl/prog/en/css/reset-fonts-grids.css The first two are symlinked from libjs-yui, the second two the ones that Koha bundles. The Koha version is quite a bit older than the debian version. This may be a problem, we I'll try it anyway. Koha is also referencing it badly: robin@zarathud:~/catalyst/koha/koha-tmpl/opac-tmpl/prog/en$ grep -r skin.css * includes/doc-head-close.inc:<link rel="stylesheet" type="text/css" href="/opac-tmpl/lib/yui/skin.css" /> modules/sco/help.tt:<link rel="stylesheet" type="text/css" href="[% yuipath %]/skin.css" /> modules/sco/sco-main.tt:<link rel="stylesheet" type="text/css" href="[% yuipath %]/skin.css" /> I think we should be referencing it from the opac.css, that way it's centralised and it can be re-written as part of the package building process. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #8 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 14110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14110&action=edit Bug 9052 - rewrite the YUI links to use the system library This uses libjs-yui to provide the skin.css and reset-fonts-grids.css files from YUI. It patches the CSS files to point to the right location for the files. To test: * Build a package with this patch included * Install it * Look at the OPAC and note that things no longer look terrible, and that there are no 404's coming from bad CSS URLs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13720|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- The patch attached hasn't had a lot of testing by me, just enough to indicate that it looks like it works. If someone else could give it a good looking at, that would be appreciated. It deliberately doesn't modify the behaviour for the staff client or the SCO-related templates. I haven't established if there are issues there or not yet, I think the OPAC is more critical. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14110|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 14118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14118&action=edit Bug 9052 - rewrite the YUI links to use the system library This uses libjs-yui to provide the skin.css and reset-fonts-grids.css files from YUI. It patches the CSS files to point to the right location for the files. To test: * Build a package with this patch included * Install it * Look at the OPAC and note that things no longer look terrible, and that there are no 404's coming from bad CSS URLs. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I created a package of 3.10+9052, installed and tested. I confirm that the OPAC does not look broken anymore and I could not find 404 errors with Firebug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net --- Comment #11 from Mirko Tietgen <mirko@abunchofthings.net> --- I have not had time do extensive testing, I mainly checked that OPAC pages look OK and Firebug does not show any errors. Given that packages are the recommended way of installation I'd like to see this pushed soon as it makes 3.10 packages usable without manual tweaking -- even if that means less extensive testing. If somebody with more time at hand would do a second signoff that would of course be appreciated. On a sidenote, I had a problem with
libdigest-jhash-perl: 0.07-1koha1 Depends: perlapi-5.10.1 but it is not installable
and had to manually install an older version of libdigest-jhash-perl in the pbuilder environment. It happened when i tried to build master+9052, which does not work anyway. I am new to the roll-your-own-packages-business so I'm not sure if it is supposed to or not, probably an error on my side. 3.10+master works and is what I based my signoff on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to comment #11)
3.10+master works and is what I based my signoff on.
That line is supposed to read '3.10+9052' works and is what I based my signoff on' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #13 from Robin Sheat <robin@catalyst.net.nz> --- Thanks for testing! The libjhash thing is completely unrelated, basically it's an annoyingly problematic package. We're going to fix that by removing that dependency, as it's optional anyway. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14118|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14159&action=edit Bug 9052 - rewrite the YUI links to use the system library This uses libjs-yui to provide the skin.css and reset-fonts-grids.css files from YUI. It patches the CSS files to point to the right location for the files. To test: * Build a package with this patch included * Install it * Look at the OPAC and note that things no longer look terrible, and that there are no 404's coming from bad CSS URLs. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I created a package of 3.10+9052, installed and tested. I confirm that the OPAC does not look broken anymore and I could not find 404 errors with Firebug. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I also created a package of 3.10+9052 and removed libchi-* from the debian/control file. The OPAC shows no problems using those packages, layout, pictures and colors seem to all be in place. Also the OPAC on master with patch applied still works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #15 from Robin Sheat <robin@catalyst.net.nz> --- I didn't think to put this in the testing notes, however it would be worth checking that these changes don't break a git or tarball install, as I have changed things that shouldn't-but-might affect that, in particular how the CSS is loaded on all OPAC pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #15)
I didn't think to put this in the testing notes, however it would be worth checking that these changes don't break a git or tarball install, as I have changed things that shouldn't-but-might affect that, in particular how the CSS is loaded on all OPAC pages.
I think Katrin tested this for a git install right ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #17 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to comment #16)
I think Katrin tested this for a git install right ?
I didn't read it that way initially, but on re-read you might be right. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, I did a git install and took a look at the OPAC there before creating the packages from that changed branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- Really, we are not going to lose anything, but win the "package installation is our recommended way" back. I think it is hardly possible that it's worse than before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #22 from Robin Sheat <robin@catalyst.net.nz> --- The staff client needs no work: it seems to keep the .css files in the language specific directory (that said, it might be nice to remove them and uses the system ones anyway, but it's not critical.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #23 from Robin Sheat <robin@catalyst.net.nz> --- It _is_ an issue for the self-checkout module. I'll patch this in the same way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #24 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 14178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14178&action=edit Bug 9052 - followup: fix the YUI CSS locations for SCO This is followup to the previous YUI-fixing patch, and simply causes the self-checkout page to load the YUI files via the sco CSS file, and that gets re-written at package build time to work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #25 from Robin Sheat <robin@catalyst.net.nz> --- Attached patch is a whole lot simpler, but the same testing process should apply as for the previous one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14178|0 |1 is obsolete| | --- Comment #26 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 14185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14185&action=edit Bug 9052 - followup: fix the YUI CSS locations for SCO This is followup to the previous YUI-fixing patch, and simply causes the self-checkout page to load the YUI files via the sco CSS file, and that gets re-written at package build time to work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14185|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14329&action=edit [SIGNED-OFF] Bug 9052 - followup: fix the YUI CSS locations for SCO This is followup to the previous YUI-fixing patch, and simply causes the self-checkout page to load the YUI files via the sco CSS file, and that gets re-written at package build time to work. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested on a package installation using packages built by Mirko Tietgen and a git dev installation. To test: 1) Enable WebBasedSelfCheck system preference 2) Enter login date for staff user in AutoSelfCheckAllowed... prefernces 3) Go to the self checkout page: .../cgi-bin/koha/sco/sco-main.pl 4) Verfiy all pages have the usual look, CSS, Javascript and images look normal 5) Verify the same is true for translated templates Manual: http://manual.koha-community.org/3.10/en/selfcheckout.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10084 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.10.x please rebase and send a new patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 --- Comment #31 from Robin Sheat <robin@catalyst.net.nz> --- This patch is already in 3.10.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9052 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org