[Bug 15261] New: Verify if checkouts or reserves requests periods overlap with existing reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Bug ID: 15261 Summary: Verify if checkouts or reserves requests periods overlap with existing reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 45216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45216&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia@hotmail.com --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- The patch does not apply, given these errors after applying: Can't locate Date/Range.pm in @INC (@INC contains: /home/koha/src /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/koha/src/Koha/DateUtils.pm line 21. BEGIN failed--compilation aborted at /home/koha/src/Koha/DateUtils.pm line 21. Compilation failed in require at /home/koha/src/C4/Search/History.pm line 7. BEGIN failed--compilation aborted at /home/koha/src/C4/Search/History.pm line 7. Compilation failed in require at /home/koha/src/C4/Auth.pm line 32. BEGIN failed--compilation aborted at /home/koha/src/C4/Auth.pm line 32. Compilation failed in require at /home/koha/src/mainpage.pl line 25. BEGIN failed--compilation aborted at /home/koha/src/mainpage.pl line 25. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- Hello, There is 2 new dependencies: Date::Range and Date::Simple that you have to install. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |gmc@esilibrary.com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #4 from delaye <stephane.delaye@biblibre.com> --- Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture Biblibre - test with http://pro.test1.biblibre.com: ok 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve Biblibre - test with http://pro.test1.biblibre.com: ok 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. Biblibre - test with http://pro.test1.biblibre.com: ok 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. Biblibre - test with http://pro.test1.biblibre.com: ok 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve Biblibre - test with http://catalogue.test1.biblibre.com: ok 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. Biblibre - test with http://catalogue.test1.biblibre.com: ok: ok 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Biblibre - test with http://catalogue.test1.biblibre.com: ok: ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Claire: Who did signoff this patch? Alex: Are you sure you cannot avoid to add the 2 deps and use DateTime to do the job? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Jonathan: I'm not sure of anything when talking about dates and programming. But Date::Range is the only tool i found that quickly checks if 2 date ranges overlap. Unfortunately, it works only with Date::Simple. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- With DateTime and DateTime::Set, I am sure you can get the same result quickly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45833&action=edit Bug 15261: remove Date::Range and Date::Simple dependencies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45833|0 |1 is obsolete| | --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45841&action=edit Bug 15261: remove Date::Range and Date::Simple dependencies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45216|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 46432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46432&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45841|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 46433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46433&action=edit Bug 15261: remove Date::Range and Date::Simple dependencies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #13 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 46441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46441&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Signed-off-by: delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #14 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 46442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46442&action=edit Bug 15261: remove Date::Range and Date::Simple dependencies Signed-off-by: delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex and Julian, some things about this patch: - Can you please add a some information about the use case of this? I am not sure about how this is used in the library. - It seems to change the behaviour, but there are no new preferences or configuration options introduced. Bit worried about this. As this touches the complicated matter of holds, I'd like to ask for another sign-off. Also to get another opinion about the mechanics of it. Adding Marcel and Kyle in CC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could you please clarify why an existing reserve and a new one should not be allowed to have some overlap in the period? In our case this may happen frequently. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #16)
Could you please clarify why an existing reserve and a new one should not be allowed to have some overlap in the period? In our case this may happen frequently.
It seems to me that this is more like treating a hold as a true reservation than a hold. It's saying "This item will go to this patron on this date, so nobody else can have it on that date". Kind of like reserving a conference room. Now, whether we should have that behavior or not is a the real question or not. This link is for another ILS and at seems to explain Holds vs Reserves vs Reservations pretty well: http://www.goalexandria.com/totw/tips/2009/100509.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- I should also note, we have Holds ( of course! ), we have Reserves ( aka Course Reserves ) but Koha doesn't really have Reservations as a first class feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle or Marcel, can you maybe explain the usual use case for the HoldDateInFuture setting? Maybe this will help to clear things up about the differences even more. I am not quite sure about myself and would like to understand better how it's currently used. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #19)
Hi Kyle or Marcel,
can you maybe explain the usual use case for the HoldDateInFuture setting? Maybe this will help to clear things up about the differences even more. I am not quite sure about myself and would like to understand better how it's currently used.
I'm not the author of HoldDateInFuture ( iirc ), so I don't really know. I think that it is basically shoehorning Reservations behavior into holds, but since I don't have a use case, I may be wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, I thought it was yours - Holds... must be Kyle! Sorry! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #21)
Ah, I thought it was yours - Holds... must be Kyle! Sorry!
lol, I can understand why ; ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #19)
can you maybe explain the usual use case for the HoldDateInFuture setting? Maybe this will help to clear things up about the differences even more. I am not quite sure about myself and would like to understand better how it's currently used.
We have enabled a.o.: AllowHoldDateInFuture, ConfirmFutureHolds=2, OPACAllowHoldDateInFuture. This offers the user to supply two additional dates with a hold request: Hold starts on date, and Hold not needed after. What does that mean? The patron tells us here that he would like to have the book only in the indicated (future) period. So we do not put the book in waiting status for him until this period is very close (ConfirmFutureHolds). In the meantime we can issue the book to someone else or let others place holds. Similarly, another patron can also say: I want this book between A and B. No problem if this overlaps the period of patron 1. Priority is here based on [future] start date. If the book could not be put in waiting status for patron 1 in the indicated period somehow, the expired hold will be cancelled. This is imo just a straightforward use of the two dates as Koha offers by default. Our specific local situation is not relevant in this discussion. Note that I am still missing any response from the authors of this patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org