[Bug 33566] New: Use template wrapper for breadcrumbs: Tools, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Bug ID: 33566 Summary: Use template wrapper for breadcrumbs: Tools, part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several tools templates so that they use the new template wrapper for breadcrumbs. - tools/access_files.tt - tools/additional-contents.tt - tools/automatic_item_modification_by_age.tt - tools/batch_delete_records.tt - tools/batch_extend_due_dates.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149940&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Everything works fine except I in the the News area. When I go to News > Edit Entry the end of the breadcrumb displays (1 News ) instead of just (News) Any entry you click on always says (1 News ) which I don't think is the intent. Also there is an extra space between News and the closing parenthesis. Home > Tools > News > Modify additional content (1 News ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149940|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 150185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150185&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150185|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 150202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150202&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150202|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150426&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org