http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- This behavior is not present in 3.12.7, but it is present on 3.15 in the sandboxes. I do not know if this is affecting 3.14. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Liz Rea from comment #2)

This probably also has to do with the report of scanners submitting new borrowers early in 3.14.

I would agree with that assessment, since scanner input often sends a CR signal. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Bug 11521 is a duplicate no ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25615|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25676&action=edit Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Bug 11563 depends on bug 11521, which changed state. Bug 11521 Summary: Patron Cardnumber scanning causing patron record to be saved. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11521 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Indeed, live is deprecated in jQuery 1.7 https://api.jquery.com/live/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Kyle M Hall from comment #10)

Created attachment 25935 [details] [review] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns

When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. In this case, shall we add noEnterSubmit on select also ? I think it does not impact other browser/OS combination.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25676|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26443&action=edit Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25935|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26445&action=edit Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #17 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #16)

(In reply to Fridolin SOMERS from comment #11)

...

In this case, shall we add noEnterSubmit on select also ? I think it does not impact other browser/OS combination.

It is not what the last patch does? No, this patch corrects behaviors for elements with "noEnterSubmit" class. But this class in actually only set on "input" elements : $("fieldset.rows input").addClass("noEnterSubmit");

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #19 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #18)

(In reply to Fridolin SOMERS from comment #17)

...

But this class in actually only set on "input" elements : $("fieldset.rows input").addClass("noEnterSubmit");

No, the *last* patch does the following : - $("fieldset.rows input").addClass("noEnterSubmit"); + $("fieldset.rows input,select").addClass("noEnterSubmit");

:) Ohhhhhh, sorry I had not seen this patch.

@Kyle : I think the JQuery selector is not correct : $("fieldset.rows input,select").addClass("noEnterSubmit"); should be : $("fieldset.rows input, fieldset.rows select").addClass("noEnterSubmit"); Also, the pages mancredit.tt and maninvoice.tt are also using noEnterSubmit class. They should have the same JS code no ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26545&action=edit Bug 11563: (followup) Disable add noEnterSubmit to pulldowns Test plan: To test on modified pages: - Press enter when cursor is on input or select and verify the form is not submitted. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #22 from Christopher Brannon <cbrannon@cdalibrary.org> --- I think the correct code would read: $("fieldset input, fieldset select").addClass("noEnterSubmit"); The .row misdirects the selector. I've tested this, and this applies correctly. However, I am not a patch writer. I'll leave that to you guys. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #24 from Christopher Brannon <cbrannon@cdalibrary.org> --- Well, ignore my comments. For some reason, it wasn't working at first. Now it is. Sorry guys. Don't know why this happens. I can confirm it works now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #26 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26560&action=edit Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #28 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26562&action=edit Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26560|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26566&action=edit Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26568&action=edit [PASSED QA] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26570&action=edit [PASSED QA] Bug 11563 - Class noEnterSubmit no longer functioning For some reason, even if an input as the class noEnterSubmit, the code found in staff-global.js for preventing submission when hitting the enter key is no longer triggered. This is because this class is added using JavaScript in $(document).ready() and the keypress event listerning is also set using $(document).ready(). This patch corrects by using JQuery live() with will set event listerning event for HTML generated with JavaScript. Alos sets noEnterSubmit to use the checkEnter(e) function, containing a more correct code. Also corrects a small bug, for IE, window.event must be used, not event alone (even if IE is not supported for intranet). Test plan : - Flush browser cache (Crtl+F5) to update js files - Go to patron creation : members/memberentrygen.tt - Type a text in all mandatory inputs - Type some caracters in a non mandatory input - Press Enter key => Without patch : the form is submitted => With patch : the form is not submitted - Try to set several lines in a textarea => It works (checks that in this case enter key is allowed) - Test other pages usign noEnterSubmit class : cataloguing/additem.tt course_reserves/course.tt members/mancredit.tt members/maninvoice.tt patron_lists/list.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tested in Firefox and Chromium. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26568|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26572&action=edit [PASSED QA] Bug 11563 [QA Followup] - Disable add noEnterSubmit to pulldowns When using Chrome on Mac OS X, form submits are triggered by hitting enter when focused on a select. This is not an issue with any other combincation of browser and operating system that I am aware of. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #39 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |costalc@gmail.com Version|master |3.16 --- Comment #40 from bondiurbano <costalc@gmail.com> --- Same problem in 3.16.4. Needs to fix file intranet-tmpl/prog/*LANG*/js/cataloging.js In LINE 486 erase 'noEnterSubmit' parameter in function addClass. - $(".input_marceditor, .indicator").addClass('noEnterSubmit'); + $(".input_marceditor, .indicator").addClass(''); -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #42 from bondiurbano <costalc@gmail.com> --- (In reply to Katrin Fischer from comment #41)

Hi Bondiurbano, can you please open a separate bug (linking to this) with a problem description?

I think if the problem is in 3.16.4 it's likely also in master, so this version should be used.

DONE! See bug 13080 addClass('noEnterSubmit') no longer functioning for 5xx tags while cataloging Thank you Katrin! -- You are receiving this mail because: You are watching all bug changes.