[Bug 29993] New: Syndetics cover images do not display in browse shelf when scrolling from the first page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Bug ID: 29993 Summary: Syndetics cover images do not display in browse shelf when scrolling from the first page Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucy.vaux-harvey@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org If you have SyndeticsCoverImages enabled the browse shelf display of cover images is broken. The first loaded page of the shelf browse displays the images correctly but if you click Next or Previous to scroll to a new page the images do not display. For example https://libsearch.aub.ac.uk/cgi-bin/koha/opac-detail.pl?biblionumber=1276&shelfbrowse_itemnumber=1539#holdings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149765&action=edit Bug 29993: Show Syndetics covers when using shelfbrowser controls 1. Have items that include itemcallnumber. 2. Enable OPACShelfBrowser. 3. Enable SyndeticsCoverImages and SyndeticsEnabled. 4. Go the an OPAC detail page and open the shelf browser. 5. Use the Next/Previous buttons. 6. Notice that no Syndetics images populate after using Next/Previous buttons. 7. Apply patch and try again, cover images for Syndetics should be generating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Version|20.11 |master Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149765|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149766&action=edit Bug 29993: Show Syndetics covers when using shelfbrowser controls 1. Have items that include itemcallnumber. 2. Enable OPACShelfBrowser. 3. Enable SyndeticsCoverImages and SyndeticsEnabled. 4. Go the an OPAC detail page and open the shelf browser. 5. Use the Next/Previous buttons. 6. Notice that no Syndetics images populate after using Next/Previous buttons. 7. Apply patch and try again, cover images for Syndetics should be generating. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #3 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- works like a charm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- test note: just put "test" in SyndeticsClientCode, it worked, that was total guesswork ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149766|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 151164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151164&action=edit Bug 29993: Show Syndetics covers when using shelfbrowser controls 1. Have items that include itemcallnumber. 2. Enable OPACShelfBrowser. 3. Enable SyndeticsCoverImages and SyndeticsEnabled. 4. Go the an OPAC detail page and open the shelf browser. 5. Use the Next/Previous buttons. 6. Notice that no Syndetics images populate after using Next/Previous buttons. 7. Apply patch and try again, cover images for Syndetics should be generating. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code ok, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org