[Bug 24282] New: SCSS conversion broke style in search results item status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Bug ID: 24282 Summary: SCSS conversion broke style in search results item status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 96505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96505&action=edit Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96505|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 96620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96620&action=edit Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96620|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96672&action=edit Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 24234 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Version(s)|20.05.00 |20.05.00, 19.05.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org