[Bug 26741] New: Make rabbitmq-server suggested rather than required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Bug ID: 26741 Summary: Make rabbitmq-server suggested rather than required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com While some parts of Koha will require RabbitMQ, we should make rabbitmq-server a suggested dependency rather than a required dependency, since it shouldn't have to be run on the same server as Koha. In fact, the RabbitMQ website explicitly recommends not collocating RabbitMQ on the same server as other applications. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 112012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112012&action=edit Bug 26741: Remove rabbitmq-server requirements (replace with suggestions) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make rabbitmq-server |Make rabbitmq-server a |suggested rather than |'recommended' package |required | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 112083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112083&action=edit Bug 26741: Make rabbitmq-server a 'recommended' package to test... 1/ apply patch, build new package 2/ install package with 'apt install koha-common', observe rabbitmq-server package is installed 3/ install package with 'apt install --no-install-recommends koha-common', observe rabbitmq-server package is *not* installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I'm trying to build on Jessie but getting the following: E: Unable to locate package libemail-stuffer-perl E: Unable to locate package libplack-middleware-logwarn-perl But Jessie is EOL iirc so I guess it's time to update the build box... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- dpkg-source: warning: unknown information field 'Recommended' in input data in package's section of control info file dpkg-source: warning: unknown information field 'Recommended' in input data in package's section of control info file That should be Recommends rather than Recommended -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 112083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112083 Bug 26741: Make rabbitmq-server a 'recommended' package Review of attachment 112083: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26741&attachment=112083) ----------------------------------------------------------------- ::: debian/koha-common.postinst @@ +261,5 @@
+# config rmq, if rmq is installed +if dpkg-query -W -f='${db:Status-Abbrev}' rabbitmq-server | grep -q ^.i ; then + rabbitmq-plugins enable rabbitmq_stomp + service rabbitmq-server restart +fi
I haven't tested this yet, but why not just do "dpkg -l rabbitmq-server"? The if/then construct will do the right thing with the exit code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 112091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112091&action=edit Bug 26741: Change information field from Recommended to Recommends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Mason James from comment #2)
Created attachment 112083 [details] [review] Bug 26741: Make rabbitmq-server a 'recommended' package
to test...
1/ apply patch, build new package
2/ install package with 'apt install koha-common', observe rabbitmq-server package is installed
3/ install package with 'apt install --no-install-recommends koha-common', observe rabbitmq-server package is *not* installed
My test plan 1. Apply the patch to a Koha git repo 2. Download https://gitlab.com/minusdavid/koha-deb-builder-docker and follow the instructions in the README 3. Run winpty docker run --rm -it debian:stretch 4. Copy the built koha-common*.deb package into the new empty Docker container 5. apt-get update 6. apt-get install wget gnupg 7. wget -q -O- https://debian.koha-community.org/koha/gpg.asc | apt-key add - 8. echo 'deb http://debian.koha-community.org/koha stable main' | tee /etc/apt/sources.list.d/koha.list 9. apt-get update 10. apt install ./<built koha-common*.deb package> 11. Review "The following NEW packages will be installed" and note rabbitmq-server is included 12. apt install --no-install-recommends ./<built koha-common*.deb package> 13. Review "The following NEW packages will be installed" and note rabbitmq-server is included -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Note that there are a lot of recommended packages that aren't installed when using "--no-install-recommends": Recommended packages: ssl-cert default-mta | mail-transport-agent exim4 | postfix | mail-transport-agent docbook-xml iamerican | ispell-dictionary wamerican | wordlist rabbitmq-server liburi-escape-xs-perl libasync-interrupt-perl libev-perl | libevent-perl libguard-perl libcgi-fast-perl libfreezethaw-perl libclass-xsaccessor-perl libclass-c3-xs-perl libconfig-tiny-perl libdevel-argnames-perl libdate-calc-xs-perl libsql-translator-perl libmoosex-nonmoose-perl gcc libmime-tools-perl libsys-hostname-long-perl libauthen-sasl-perl libdevel-lexalias-perl libglib2.0-data xdg-user-dirs libpod-coverage-perl libtest-pod-perl ghostscript gsfonts libintl-xs-perl javascript-common libjson-xs-perl libnet-idn-encode-perl krb5-locales liblog-dispatch-perl libipc-shareable-perl libmath-random-isaac-xs-perl libev-perl libio-socket-ip-perl libio-socket-socks-perl libmojo-server-fastcgi-perl libdevel-partialdump-perl libgpm2 libgssapi-perl libio-pty-perl libtext-wrapper-perl libfcgi-perl libfcgi-procmanager-perl libmodule-refresh-perl libhijk-perl libhtml-lint-perl libtype-tiny-xs-perl tcpd libwww-form-urlencoded-xs-perl libxml-sax-expat-perl libtie-ixhash-perl libxml-xpathengine-perl | libxml-xpath-perl libterm-readkey-perl bzip2 file xz-utils xauth rename psmisc libserver-starter-perl I think that this probably will have unintended consequences, so I'm thinking it's best to fail this one for now. I think the original idea of using Suggests rather than Recommends might be the safest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112012|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make rabbitmq-server a |Make rabbitmq-server |'recommended' package |suggested rather than | |required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112012|0 |1 is obsolete| | --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Created attachment 112972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112972&action=edit Bug 26741: Remove rabbitmq-server requirements (replace with suggestions) Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #8)
Note that there are a lot of recommended packages that aren't installed when using "--no-install-recommends":
I think the original idea of using Suggests rather than Recommends might be the safest.
i'm happy with this idea, so i sign-off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Mason James from comment #10)
i'm happy with this idea, so i sign-off :)
Great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- When this and related bugs are pushed, we can also update koha-testing-docker to use a separate Docker container for the RabbitMQ server... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
4. Copy the built koha-common*.deb package into the new empty Docker container
Like with a volume? Also, got an error when building, reported here: https://gitlab.com/minusdavid/koha-deb-builder-docker/-/issues/1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #13)
4. Copy the built koha-common*.deb package into the new empty Docker container
Like with a volume?
Nah just with "docker cp"
Also, got an error when building, reported here: https://gitlab.com/minusdavid/koha-deb-builder-docker/-/issues/1
Yeah, I'm fairly familiar with that error at this point. I'll comment there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Why was the shebang changed in /debian/koha-common.postinst ? -#!/bin/sh +a!/bin/sh -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 13. Review "The following NEW packages will be installed" and note rabbitmq-server is included Not included right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #15)
Why was the shebang changed in /debian/koha-common.postinst ?
-#!/bin/sh +a!/bin/sh
That's definitely a vim typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #16)
13. Review "The following NEW packages will be installed" and note rabbitmq-server is included
Not included right?
Hopefully... October feels a long time ago. I'd probably mark this as Failed QA. I doubt I'm going to work on it again though. Plus, I think that this is handled by a different bug now anyway... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- For the record,
11. Review "The following NEW packages will be installed" and note rabbitmq-server is included
Indeed, rabbitmq-server is listed in: - The following additional packages will be installed: - The following NEW packages will be installed:
13. Review "The following NEW packages will be installed" and note rabbitmq-server is included
Indeed, rabbitmq-server is listed in: - The following additional packages will be installed: - The following NEW packages will be installed: (In reply to David Cook from comment #18)
(In reply to Victor Grousset/tuxayo from comment #16)
13. Review "The following NEW packages will be installed" and note rabbitmq-server is included
Not included right?
Hopefully... October feels a long time ago.
I don't know, the original text matches the test plan results, so maybe I just confused you ^^
I'd probably mark this as Failed QA.
I doubt I'm going to work on it again though. Plus, I think that this is handled by a different bug now anyway...
Failed QA (+unassigned) is because that would better indicate that this can be eventually rescued right? Compared to in discussion. (not an expert in statuses ^^) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #19)
Failed QA (+unassigned) is because that would better indicate that this can be eventually rescued right? Compared to in discussion. (not an expert in statuses ^^)
You're probably right. Although I keep thinking that Mason, myself, and others talked about how we're going to stay with "requires" for the time being. I can't find that conversation now though. Plus Bug 26672 provides some alternatives for people who don't want to install rabbitmq-server on the same server, although I'm not sure how functional those are in practice.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26672 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We answer this problem with the new debian packages: koha-core vs koha-full. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Bug 26741 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org