[Bug 29052] New: Make consistent use of spans and div with hint class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Bug ID: 29052 Summary: Make consistent use of spans and div with hint class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When adding help text alongside input fields in staff interface forms the text should be wrapped in <span class="hint"> or <div class="hint">. This patch will make corrections to several pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125014&action=edit Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29052: Make consistent use of spans and div with hint class Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 29052: Make consistent use of spans and div with hint class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125014|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126447&action=edit Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126447|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 126467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126467&action=edit Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 126468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126468&action=edit Bug 29052 – Form field label display (before and after) One very small difference (and not a showstopper for me) is the display of the form field labels. They seem to wrap around more rather than display on one line - see the attached example. The Add item type (which I didn't take a screen shot of) is probably a better example. Overall, a really nice improvement! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126467|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126549&action=edit Bug 29052: Make consistent use of spans and div with hint class This patch makes minor HTML corrections to several templates, primarily to wrap form help text in <span class="hint"> or <div class="hint">. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View the following pages to confirm that forms look correct: - Administration -> Authority types -> Authority type -> Edit. - Administration -> Authority types -> Authority type -> MARC structure. -> Subfields -> Edit. - Administration -> Authorised values -> View category -> New authorized value. - Administration -> Credit types -> New credit type. - Administration -> Debit types -> New debit type. - Administration -> Item types -> New item type. Also changed: Added link to ITEMTYPECAT authorized value page for users with the correct permission. - Administration -> MARC frameworks -> MARC structure -> Edit subfields. - Administration -> Patron attribute types -> New patron attribute type. - Administration -> Share content with Mana KB. - Administration -> Z39.50/SRU servers -> New Z39.50 server. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I especially like the changes to the Z39.50 server page. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org