[Bug 28390] New: Transaction timestamps on POS Register Transaction details pages should denote 'Money changed hands' time, not 'Debt added' time.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Bug ID: 28390 Summary: Transaction timestamps on POS Register Transaction details pages should denote 'Money changed hands' time, not 'Debt added' time. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The rowGrouped table for listing transactions taken against a cash register had 'timestamp' added for display in bug 28127. This his great, however; * The timestamp added is at the individual line level and not the grouped transaction level. This means that for a payment we're actually displaying the times at which each debt was created and not the time the payment was made. This is OK for POS sales, as they will always match the Payment time (though it does look odd having duplicates).. but for payments made against a patrons account that can also appear on these pages it could get quite confusing and misleading. I propose that we use the payment line timestamp instead and move it to the grouping header row. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Depends on| |28127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 [Bug 28127] POS register details tables should have a transaction date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121179&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transaction timestamps on |Transaction timestamps |POS Register Transaction |should be part of the |details pages should denote |transaction grouping row |'Money changed hands' time, |instead of repeated for |not 'Debt added' time. |each breakdown row -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121179|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121187&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Martin. Looks nicer, functions better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Martin, Any chance for a rebase of this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121187|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123422&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 [Bug 28389] One should be able to see details for refunds on the register summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123422|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123478&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another minor rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123478|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123585&action=edit Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Bug 28390 depends on bug 28127, which changed state. Bug 28127 Summary: POS register details tables should have a transaction date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org