https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 67165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67165 Bug 11300 - Add a new authority linker which searches for authority links on a Z39.50 server. Review of attachment 67165: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11300&attachment=67165) ----------------------------------------------------------------- Hi Bouzid, noted some thing in the splinter review. Additionally: - atomicupdate for adding the system preference is missing - You will have to add tests for the new module to pass QA - QA tools show some fails: OK C4/Biblio.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL C4/Linker/Z3950Server.pm FAIL critic Found use of Switch. This module is deprecated by the Perl 5 Porters at line 223, column 5. Find an alternative module. OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for flip_heading POD is missing for getZ3950Authority POD is missing for get_link POD is missing for update_cache OK spelling OK valid OK cataloguing/automatic_linker.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid FAIL installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon FAIL sysprefs_order Not blocker: Sysprefs AdditionalFieldsInZ3950ResultSearch is bad placed (see bug 10610) - I've tried to configure and test the feature, but see an alert with an internal server error. Plack error logs show: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_cataloguing_automatic_linker_2epl line 65, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. Personal-name,do-not-truncate,ext="K�rger, Walter Christian" ZOOM error 114 "Unsupported Use attribute" (addinfo: "Personal-name") from diag-set 'Bib-1' at /home/vagrant/kohaclone/C4/Linker/Z3950Server.pm line 260. Can't locate object method "get_link" via package "C4::Linker::Default" (perhaps you forgot to load "C4::Linker::Default"?) at /home/vagrant/kohaclone/C4/Biblio.pm line 533. ::: C4/Linker/Z3950Server.pm @@ +15,5 @@

+# You should have received a copy of the GNU General Public License +# along with Koha; if not, see <http://www.gnu.org/licenses>. + +use strict; +use warnings;

Please use Modern::Perl instead! ::: installer/data/mysql/sysprefs.sql @@ +8,5 @@

('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), ('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), +('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'), +('AddressFormat','us','','Choose format to display postal addresses', 'Choice'),

I think there is a merge error here - the new pref (LinkerZ3950Server) is missing and others are doubled up. -- You are receiving this mail because: You are watching all bug changes.