[Bug 35857] New: Update display of Clear and Cancel links in the authority search pop-up window
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Bug ID: 35857 Summary: Update display of Clear and Cancel links in the authority search pop-up window Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While documenting bug 31132, I noticed the links in the authority search pop-up window don't look like the other links in Koha. As far as I know, the Cancel links are usually green and become underlined on hover. Here, it is black and not underlined and the Clear form link is blue and becomes green on hover. To access the pop-up: 1. Go to Cataloging > New record 2. Go to a field that is linked to authorities (for example, in MARC21, 100 or 650) 3. Click the Tag editor button at the end of the $a subfield -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161560&action=edit Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161560|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 161562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161562&action=edit Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161562|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 163693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163693&action=edit Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35857 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38066 [Bug 38066] New authority finder footer blocks page content -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org