[Bug 27739] New: Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Bug ID: 27739 Summary: Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 27738 cateditor-widgets-marc21.inc uses DefaultLanguageField008 for the initial value of the language in 008/35-37, but just hardcodes xxu rather than using the companion pref DefaultCountryField008 for 008/15-17. Since using the pref requires a fallback when it's unset, and bug 27738 proposes changing the current fallback in the basic editor, this bug should wait on an outcome there before being fixed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 119092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119092&action=edit Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119092|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119146&action=edit Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119146|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119681&action=edit Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- This makes behavior match the basic cataloging editor, nice work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Bug 27739 depends on bug 27738, which changed state. Bug 27738 Summary: Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org