[Bug 27481] New: Use Modern::Perl in cataloguing unimarc plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Bug ID: 27481 Summary: Use Modern::Perl in cataloguing unimarc plugins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org use Modern::Perl in the place of use strict; use warnings; cataloguing/value_builder/unimarc_field_105.pl cataloguing/value_builder/unimarc_field_110.pl cataloguing/value_builder/unimarc_field_120.pl cataloguing/value_builder/unimarc_field_130.pl cataloguing/value_builder/unimarc_field_140.pl cataloguing/value_builder/unimarc_field_225a.pl cataloguing/value_builder/unimarc_field_4XX.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherinem2003@gmail.com Assignee|koha-bugs@lists.koha-commun |catherinem2003@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 --- Comment #1 from Catherine <catherinem2003@gmail.com> --- Created attachment 115410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115410&action=edit Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins Test plan: Check Modern::Perl is used in the place of use strict; use warnings; Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 --- Comment #2 from Catherine <catherinem2003@gmail.com> --- Hi, I am still working on this. Please don't test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115410|0 |1 is obsolete| | --- Comment #3 from Catherine <catherinem2003@gmail.com> --- Created attachment 115456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115456&action=edit Bug 27481:Use 'Modern::Perl' in cataloguing unimarc plugins In this bug Modern::Perl was not used because #use warnings; was a comment so Modern:: Perl did not apply Test plan: 1. Add patch 2. Check use strict; is used in the files below cataloguing/value_builder/unimarc_field_105.pl cataloguing/value_builder/unimarc_field_110.pl cataloguing/value_builder/unimarc_field_120.pl cataloguing/value_builder/unimarc_field_130.pl cataloguing/value_builder/unimarc_field_140.pl cataloguing/value_builder/unimarc_field_225a.pl cataloguing/value_builder/unimarc_field_4XX.pl Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch is not doing what it is advertising. We should use Modern::Perl, not removing a line that is commented-out. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org