[Bug 42282] New: Tidy all script tags - catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Bug ID: 42282 Summary: Tidy all script tags - catalogue Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags (except value_builder) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196783&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196784&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Patch from commit c713743 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196915&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196916&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Patch from commit 9a963de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197063&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197064&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Patch from commit 94d47c2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197574&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197575&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197576&action=edit Bug 42282: (follow-up) Fix broken mailto concatenation in Elasticsearch 404 modal The port folded the admin email into a single string literal " <a href='mailto: + Koha.prefs.KohaAdminEmailAddress'>" so the href became the literal text "mailto: + Koha.prefs..." instead of mailto:<admin email>. Close the string and concatenate Koha.prefs.KohaAdminEmailAddress. To test: - Set KohaAdminEmailAddress syspref. - SearchEngine = Elasticsearch, open a biblio detail page. - Trigger the Elasticsearch preview with a bad id so the 404 branch renders, and confirm the "Send email" link points at mailto:<email>. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197577&action=edit Bug 42282: (follow-up) Switch Coce timeout log to console.warn qa script flags the stray console.log in the Coce wait-for-images helper under forbidden_patterns. The line is a genuine soft-failure diagnostic (Coce never resolved after 5s), matching the console.warn pattern used for AJAX failures elsewhere in the staff templates. To test: - qa script no longer flags forbidden_patterns on detail.tt. - With IntranetCoce enabled but Coce unreachable, loading a biblio logs "Could not retrieve the images" as a warning after ~5s. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Signed Off |Patch doesn't apply --- Comment #11 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198501&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198502&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198503&action=edit Bug 42282: (follow-up) Fix broken mailto concatenation in Elasticsearch 404 modal The port folded the admin email into a single string literal " <a href='mailto: + Koha.prefs.KohaAdminEmailAddress'>" so the href became the literal text "mailto: + Koha.prefs..." instead of mailto:<admin email>. Close the string and concatenate Koha.prefs.KohaAdminEmailAddress. To test: - Set KohaAdminEmailAddress syspref. - SearchEngine = Elasticsearch, open a biblio detail page. - Trigger the Elasticsearch preview with a bad id so the 404 branch renders, and confirm the "Send email" link points at mailto:<email>. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198504&action=edit Bug 42282: (follow-up) Switch Coce timeout log to console.warn qa script flags the stray console.log in the Coce wait-for-images helper under forbidden_patterns. The line is a genuine soft-failure diagnostic (Coce never resolved after 5s), matching the console.warn pattern used for AJAX failures elsewhere in the staff templates. To test: - qa script no longer flags forbidden_patterns on detail.tt. - With IntranetCoce enabled but Coce unreachable, loading a biblio logs "Could not retrieve the images" as a warning after ~5s. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #11)
The patches no longer apply 8-(..
Rebased, you will need: "Bug 42177: bundlesEnabled fix" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198501|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198596&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198597&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198598&action=edit Bug 42282: (follow-up) Fix broken mailto concatenation in Elasticsearch 404 modal The port folded the admin email into a single string literal " <a href='mailto: + Koha.prefs.KohaAdminEmailAddress'>" so the href became the literal text "mailto: + Koha.prefs..." instead of mailto:<admin email>. Close the string and concatenate Koha.prefs.KohaAdminEmailAddress. To test: - Set KohaAdminEmailAddress syspref. - SearchEngine = Elasticsearch, open a biblio detail page. - Trigger the Elasticsearch preview with a bad id so the 404 branch renders, and confirm the "Send email" link points at mailto:<email>. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198599&action=edit Bug 42282: (follow-up) Switch Coce timeout log to console.warn qa script flags the stray console.log in the Coce wait-for-images helper under forbidden_patterns. The line is a genuine soft-failure diagnostic (Coce never resolved after 5s), matching the console.warn pattern used for AJAX failures elsewhere in the staff templates. To test: - qa script no longer flags forbidden_patterns on detail.tt. - With IntranetCoce enabled but Coce unreachable, loading a biblio logs "Could not retrieve the images" as a warning after ~5s. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 [Bug 42440] Remove event attributes from labeled MARC detail template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198608&action=edit Bug 42282: Avoid JS error Fix conflict with "Bug 42177: bundlesEnabled fix" SyntaxError: redeclaration of const bundlesEnabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #16)
(In reply to David Nind from comment #11)
The patches no longer apply 8-(..
Rebased, you will need: "Bug 42177: bundlesEnabled fix"
It still applies on top of this follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42283 [Bug 42283] Tidy all script tags - cataloguing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198596|0 |1 is obsolete| | Attachment #198597|0 |1 is obsolete| | Attachment #198598|0 |1 is obsolete| | Attachment #198599|0 |1 is obsolete| | Attachment #198608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #23 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200005&action=edit Bug 42282: Tidy all script tags - catalogue In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the catalogue module. The 7 main changes are in the following files: * ISBDdetail.tt * MARCdetail.tt * detail.tt * imageviewer.tt * labeledMARCdetail.tt * moredetail.tt * stockrotation.tt Several identical changes (logged_in_user_borrowernumber, searchid, biblio_id, browser, etc.) detail.tt needs to be tested a bit more thoroughly but the changes are still trivial. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #24 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200006&action=edit Bug 42282: Tidy all script tags - catalogue (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #25 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200007&action=edit Bug 42282: (follow-up) Fix broken mailto concatenation in Elasticsearch 404 modal The port folded the admin email into a single string literal " <a href='mailto: + Koha.prefs.KohaAdminEmailAddress'>" so the href became the literal text "mailto: + Koha.prefs..." instead of mailto:<admin email>. Close the string and concatenate Koha.prefs.KohaAdminEmailAddress. To test: - Set KohaAdminEmailAddress syspref. - SearchEngine = Elasticsearch, open a biblio detail page. - Trigger the Elasticsearch preview with a bad id so the 404 branch renders, and confirm the "Send email" link points at mailto:<email>. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #26 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200008&action=edit Bug 42282: (follow-up) Switch Coce timeout log to console.warn qa script flags the stray console.log in the Coce wait-for-images helper under forbidden_patterns. The line is a genuine soft-failure diagnostic (Coce never resolved after 5s), matching the console.warn pattern used for AJAX failures elsewhere in the staff templates. To test: - qa script no longer flags forbidden_patterns on detail.tt. - With IntranetCoce enabled but Coce unreachable, loading a biblio logs "Could not retrieve the images" as a warning after ~5s. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #27 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200009&action=edit Bug 42282: Avoid JS error Fix conflict with "Bug 42177: bundlesEnabled fix" SyntaxError: redeclaration of const bundlesEnabled Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #28 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200010&action=edit Bug 42282: (QA follow-up): Fix call of HTML5MediaEnabled and HTML5MediaSets.size This switches the assignment of Koha.prefs.HTML5MediaEnabled from a non existant template param HTML5MediaEnabled to Koha.Preference('HTML5MediaEnabled'). Also a straying template param HTML5MediaSets.size was left in a JS block. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #29 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200011&action=edit Bug 42282: (QA follow-up) restore searchid in stockrotation This patch sets the TT param searchid to enable browsing though search results on stockrotation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #30 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200012&action=edit Bug 42282: (QA follow-up) Split JS to TT block in advsearch, auto tidy Splits JS to TT and non TT block. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #31 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200013&action=edit Bug 42282: (QA follow-up) Split JS to TT block in results, auto tidy Splits JS to TT and non TT block. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 --- Comment #32 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement will not be backported to 26.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org