[Bug 31343] New: DataTables error on waitingreserves.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Bug ID: 31343 Summary: DataTables error on waitingreserves.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Have some waiting holds 2. Go to waitingreserves.tt 3. The table loads but notice the 'cancel_selected_holds' button is an empty button. 4. Look at the console and notice the "Uncaught TypeError: settings is null" error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31138 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This is caused by Bug 31138. I don't think I understand why that change was made. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 [Bug 31138] DataTables is not raising error to the end user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #1)
This is caused by Bug 31138. I don't think I understand why that change was made.
To catch errors or mistakes, see bug 31138 comment 0. It is more obvious when you have an error server-side: the table was empty with nothing to tell the user that something wrong happened. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139048&action=edit Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139049&action=edit Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #2)
(In reply to Owen Leonard from comment #1)
This is caused by Bug 31138. I don't think I understand why that change was made.
To catch errors or mistakes, see bug 31138 comment 0. It is more obvious when you have an error server-side: the table was empty with nothing to tell the user that something wrong happened.
And here it caught a mistake ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22456 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- First patch is a follow-up of bug 31138, second patch is a follow-up of bug 22456. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 [Bug 22456] Allow patrons to cancel their waiting holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139048|0 |1 is obsolete| | Attachment #139049|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 139053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139053&action=edit Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 139054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139054&action=edit Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139053|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139499&action=edit Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139054|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139500&action=edit Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Bug 31343 depends on bug 31138, which changed state. Bug 31138 Summary: DataTables is not raising error to the end user https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 22.05.x dependencies, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343 Bug 31343 depends on bug 22456, which changed state. Bug 22456 Summary: Allow patrons to cancel their waiting holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org