https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 [Bug 19851] Improve responsive layout handling of staff client menu bar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71234&action=edit Bug 20135: Staff client language choose pop-up can appear off-screen This patch fixes a bug which was introduced by Bug 19851 ("Improve responsive layout handling of staff client menu bar."). The changes in that patch did not take into account the effects it would have on the language menus in the footer. This patch adds some additional classes to some menus and adds some CSS for those classes so that menus are correctly aligned left or right based on their position on the screen. To test, apply the patch and clear your cache if necessary. You should have multiple translations installed and enabled, at least one of which should have more than one "sub-language" (e.g. en-GB and en-US). In the staff client, test the appearance of various drop-down menus with the browser width above and below 800 pixels wide: - Search and More menus in the header - User/Library menu in the header - Language selection in the footer - Language selection in the header In all cases, menus should look correct and should not be aligned in such a way that they disappear off the left or right sides of the screen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71234|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71479&action=edit Bug 20135: Staff client language choose pop-up can appear off-screen This patch fixes a bug which was introduced by Bug 19851 ("Improve responsive layout handling of staff client menu bar."). The changes in that patch did not take into account the effects it would have on the language menus in the footer. This patch adds some additional classes to some menus and adds some CSS for those classes so that menus are correctly aligned left or right based on their position on the screen. To test, apply the patch and clear your cache if necessary. You should have multiple translations installed and enabled, at least one of which should have more than one "sub-language" (e.g. en-GB and en-US). In the staff client, test the appearance of various drop-down menus with the browser width above and below 800 pixels wide: - Search and More menus in the header - User/Library menu in the header - Language selection in the footer - Language selection in the header In all cases, menus should look correct and should not be aligned in such a way that they disappear off the left or right sides of the screen. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71479|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71533&action=edit Bug 20135: Prevent staff client language choose pop-up from appearing off-screen This patch fixes a bug which was introduced by Bug 19851 ("Improve responsive layout handling of staff client menu bar."). The changes in that patch did not take into account the effects it would have on the language menus in the footer. This patch adds some additional classes to some menus and adds some CSS for those classes so that menus are correctly aligned left or right based on their position on the screen. To test, apply the patch and clear your cache if necessary. You should have multiple translations installed and enabled, at least one of which should have more than one "sub-language" (e.g. en-GB and en-US). In the staff client, test the appearance of various drop-down menus with the browser width above and below 800 pixels wide: - Search and More menus in the header - User/Library menu in the header - Language selection in the footer - Language selection in the header In all cases, menus should look correct and should not be aligned in such a way that they disappear off the left or right sides of the screen. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.