[Bug 20492] New: Add missing case for advanced search in _fix_limit_special_cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Bug ID: 20492 Summary: Add missing case for advanced search in _fix_limit_special_cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add missing case for |Add missing case for |advanced search in |advanced search year limit |_fix_limit_special_cases |in _fix_limit_special_cases --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- If choosing "more options" in advanced search, and using "year" limit, this will not be converted to elastic query syntax format. Added a case to fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 73412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73412&action=edit Bug 20492: Add missing case for advanced search year limit Add missing case for when using "year" limit in advanced search, which results the zebra limit "yr,st-numeric=YYYY-YYYY". This will now be convered to an ElasticSearch range. How to test: 1) Perform a year limit search by choosing "More options" in advanced search page and enter a year range that should produce results. 2) This should not produce the expected results. 3) Apply patch 4) Perform the same search again, it should now produce the expected results. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com --- Comment #3 from Cab Vinton <bibliwho@gmail.com> --- It would be helpful to know what specifically the ElasticSearch syntax format is supposed to look like. Sandbox 13 is still showing "yr,st-numeric=YYYY-YYYY" for the Year limit search in both the OPAC & staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Yes, but it will be converted to the right format, so both formats are supported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Hi David, This does work, however only in OPAC, publication year in staff is not affected and still does not work in Elasticsearch Also, I think the test for this change is needed... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24807 Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure how this relates to bug 24807. I applied the patch and reindexed my records with -d, but the search in OPAC doesn't work for me. I did a date range search for "2000-", but almost all records are way before 2000, both in 008 and 260/264. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #7 from David Gustafsson <glasklas@gmail.com> --- Thing this have now been fixed in https://github.com/Koha-Community/Koha/commit/2293e6597c69d55ce5916b7a31029f... so closing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- *** This bug has been marked as a duplicate of bug 22524 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org