http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21534&action=edit Bug 10963 - [2/9] - Simplified creation of MARC21 sample frameworks Patch 2/9 This patch modifies simple bibs frameworks for BKS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21536&action=edit Bug 10963 - [4/9] - Simplified creation of MARC21 sample frameworks Patch 4/9 This patch modifies simple bibs frameworks for VR -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21538&action=edit Bug 10963 - [6/9] - Simplified creation of MARC21 sample frameworks Patch 6/9 This patch modifies simple bibs frameworks for AR -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21540&action=edit Bug 10963 - [8/9] - Simplified creation of MARC21 sample frameworks Patch 8/9 This patch modifies simple bibs frameworks for IR -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Patch is too big to fit, so I splitted it in 9 patches Here main description and test plan Bug 10963 - Simplified creation of MARC21 sample frameworks This patch series implements the creation of sample frameworks using MARC21 default framework as base, just by copy it. There are lots of obsoleted tags/subtags, but if default is the recommended then as far as they remain hidden I think there is no problem. Only to new installs To test: 1) Apply all patches 2) Remove all frameworks 3) Load default MARC21 framework 4) Load marc21_fastadd_framework.sql 5) Verify that Fast Add framework has same tags as before 6) Load marc21_simple_bib_frameworks.sql 7) Verify all sample frameworks are created -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #12 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- I really like the idea for this patch, as it will mean that we only need to manage the default framework for adding/modifying MARC fields and subfields when doing a fresh install. However...it seems to me that it is completely copying the subfields as is which is different from what we're currently doing. If you run the following SQL: "select group_concat(frameworkcode),hidden,tagfield,tagsubfield from marc_subfield_structure group by concat(tagfield,tagsubfield,hidden);" You'll notice that the other sample frameworks hide different fields that the default framework displays. I think we can still keep the methodology set out in these frameworks, but maybe we want to come up with some criteria (or copy the existing criteria) for hiding subfields/fields in these other sample frameworks. Otherwise, libraries are just going to have to customize every framework and then it becomes pointless having "other" sample frameworks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Elaine Bradtke <eb@efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb@efdss.org --- Comment #16 from Elaine Bradtke <eb@efdss.org> --- I have a few custom frameworks that we use - modified from those available on the wiki. I will attach the two that I've edited. FA = Fast add - the original one was lacking some critical fields for our library. ART = Articles - for periodical / journal articles the original of this was also lacking fields we needed. I don't know how useful they will be, ours is an unusual library. I tried to cut out as many of the extra / obsolete fields as I could. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #18 from Elaine Bradtke <eb@efdss.org> --- Created attachment 22206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22206&action=edit Framework for articles Sample framework for journal articles used in the VWML -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Elaine, the goal of this bug is a bit different, as the idea is to change the way we create the specified frameworks on database level. But we have a place for your frameworks on the wiki - http://wiki.koha-community.org/wiki/MARC_frameworks. If you want, you can upload them there or I can do it - just let me know. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, looking at David's and Bernardo's conversation I think this needs a bit more work. I think we'd need to copy the standard framework, but keep the hidden values of the current simple frameworks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 23330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23330&action=edit hidden-differences-no-new.txt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Thank's Katrin, In Discussion is the rigth state! I was working on this, now I will share what I found 1) Following David on comment #14 I did this query (only default and simple fw loaded) select tagfield, tagsubfield, hidden, group_concat(frameworkcode order by frameworkcode) as fws from marc_subfield_structure group by concat(tagfield,tagsubfield,hidden) having fws <> ',AR,BKS,CF,IR,KT,SER,SR,VR'; The result show where fw differs on hidden value between them. 2) The rearranged results, can be seen on attached file hidden-differences.txt (N for NULL value) There are 635 lines on that file, most are from subfields present on default but not in simple fw 3) As we are looking for customizations, I'll discard all new subfields, they will be copied anyway. Results on attached file hidden-differences-no-new.txt Now they are "only" 296 lines. But they are still a lot of updates to do on a copied fw, not practical 4) What I saw is that many subfields on simple fw have identical value on hidden field, but not on default fw. PROPOSAL: when all simple fw agrees on a hidden value, we set default with that value That will leave us with "real" customizations 5) With that proposal, results on attached file hidden-real.txt There are only 39 lines now. And only hidden values are -6, -1 and 0 Just to remember: -6 => OPAC Intranet !Editor !Collapsed -1 => OPAC Intranet Editor Collapsed 0 => OPAC Intranet Editor !Collapsed If we change -1 for 0 (if it's on editor, why collapsed?), we can take out a few more lines, but that's enough 6) Well, if there is a clear customization plan on hidden-real.txt, it's difficult for me to see it (except a few subfields) For me is more like a pseudo-random distribution of 3 values on 39 subfields out of 3959 on 9 fw :-) If we are going to provide simple fw with a meaning. I expect directives like: On serials and ..., hide 020 and ... On books and ..., hide 022 and ... etc. In that way, if we have a default fw with some sort of visibility on all fields/subs, we can hide at field level on simple fw. Writing all update lines needed to implement hidden-real "as is" is doable, and I already did it (without my proposal, around ~300 lines), so if I have no more comments on how to do this right, I will upload it and switch to need signoff. Regards, B -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Ready to be signed! It makes all simple and fastadd fw as copies of default and preserves previous hidden values, so no change except new fields. But.. I think that we will have a big conflict with Bug 11330, first patch needs to be discarded except for changes on default, and Katrin's followup can stay. Or.. this can be rewritten. It's one or the other. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Katrin, I will look into this again and try to make a new patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21535|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27057&action=edit Bug 10963 - Simplified creation - BKS framework Patch 2/9 This patch rewrites BKS framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27059&action=edit Bug 10963 - Simplified creation - SR framework Patch 4/9 This patch rewrites SR framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #35 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27061&action=edit Bug 10963 - Simplified creation - AR framework Patch 6/9 This patch rewrites AR framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #37 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27063&action=edit Bug 10963 - Simplified creation - IR framework Patch 8/9 This patch rewrites IR framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #39 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27065&action=edit Bug 10963 - Revert old hidden values This patch reverts old hidden values to marc_subfield_structure. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12477 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #41 from Mirko Tietgen <mirko@abunchofthings.net> --- Patch does not apply. I already did half the test plan, I'd continue testing if you'd rebase it. Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 10963 - Simplified creation - FA framework Applying: Bug 10963 - Simplified creation - BKS framework Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27057|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36461&action=edit Bug 10963: Simplified creation - BKS framework Patch 2/9 This patch rewrites BKS framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27059|0 |1 is obsolete| | --- Comment #45 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36463&action=edit Bug 10963: Simplified creation - SR framework Patch 4/9 This patch rewrites SR framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27061|0 |1 is obsolete| | --- Comment #47 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36465&action=edit Bug 10963: Simplified creation - AR framework Patch 6/9 This patch rewrites AR framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27063|0 |1 is obsolete| | --- Comment #49 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36467&action=edit Bug 10963: Simplified creation - IR framework Patch 8/9 This patch rewrites IR framework -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27065|0 |1 is obsolete| | --- Comment #51 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36469&action=edit Bug 10963: Revert old hidden values This patch reverts old hidden values to marc_subfield_structure. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36460|0 |1 is obsolete| | Attachment #36461|0 |1 is obsolete| | Attachment #36462|0 |1 is obsolete| | Attachment #36463|0 |1 is obsolete| | Attachment #36464|0 |1 is obsolete| | Attachment #36465|0 |1 is obsolete| | Attachment #36466|0 |1 is obsolete| | Attachment #36467|0 |1 is obsolete| | Attachment #36468|0 |1 is obsolete| | Attachment #36469|0 |1 is obsolete| | --- Comment #53 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36479&action=edit Bug 10963: Simplified creation - FA framework Patch 1/9 This patch modifies Fast Add framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #55 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36481&action=edit Bug 10963: Simplified creation - CF framework Patch 3/9 This patch rewrites CF framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #57 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36483&action=edit Bug 10963: Simplified creation - VR framework Patch 5/9 This patch rewrites VR framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #59 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36485&action=edit Bug 10963: Simplified creation - KT framework Patch 7/9 This patch rewrites KT framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #61 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36487&action=edit Bug 10963: Simplified creation - SER framework Patch 9/9 This patch rewrites SER framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #63 from Mirko Tietgen <mirko@abunchofthings.net> --- Followed the test plan in comment 26, diffs contain no lines. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |Patch doesn't apply --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- Bernardo, This does not longer apply. What is the plan here? I am under the impression we should not lag too much, it will be a pain to maintain this patch set if master moves! Do you generate manually or using a script? What is your confidence level in this patch set? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #66 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #64)

Bernardo, This does not longer apply. What is the plan here? I am under the impression we should not lag too much, it will be a pain to maintain this patch set if master moves! Do you generate manually or using a script? What is your confidence level in this patch set?

Hi, only needed to replace the first patch, a single line difference on FA fw. The plan is simplify current sample fw sql files, no problem with that because they are not updated since long time. What I check with a script are default frameworks (bib or auth) With this patches we generate sample fw copying from default, so no need to update them, but only works at install time. This need a followup to use the same procedure on each language, will do that later. Reverted to Signed-Off status -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #68 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #67)

There is a lof of changes, is it expected?

Yes. The purpose of the patch is to have a the same number of fields/subfields on all frameworks. I'm only updating MARC21 default, and cait always asks what to do with the others. Before patch we have select a.frameworkcode, a.tag, b.subfield from (select frameworkcode, count(*) as tag from marc_tag_structure group by frameworkcode) a left join (select frameworkcode, count(*) as subfield from marc_subfield_structure group by frameworkcode) b on a.frameworkcode = b.frameworkcode; +---------------+-----+----------+ | frameworkcode | tag | subfield | +---------------+-----+----------+ | | 340 | 3978 | | AR | 313 | 3620 | | BKS | 313 | 3620 | | CF | 313 | 3620 | | FA | 17 | 118 | | IR | 313 | 3619 | | KT | 313 | 3620 | | SER | 313 | 3619 | | SR | 313 | 3620 | | VR | 313 | 3620 | +---------------+-----+----------+ (There is a 'bug' on simple fw file, fixed here, on line 10399, fw code is incorrect 'SF' -> 'SR') After patch +---------------+-----+----------+ | frameworkcode | tag | subfield | +---------------+-----+----------+ | | 340 | 3978 | | AR | 340 | 3978 | | BKS | 340 | 3978 | | CF | 340 | 3978 | | FA | 18 | 173 | | IR | 340 | 3978 | | KT | 340 | 3978 | | SER | 340 | 3978 | | SR | 340 | 3978 | | VR | 340 | 3978 | +---------------+-----+----------+ So yes, you will see differences. All new (by me) fields/subfields have hidden = -6, they don't show on 'new' fw. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #70 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #69)

For instance:

... If my eyes are not too tired, it means that 711$c becomes repeatable.

Your eyes are right, but... it is repeatable :) (http://www.loc.gov/marc/bibliographic/bd711.html) If there is any problem, it's on default fw. The others are just copying from it. Couldn't find any discrepancy, but could be. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36480|0 |1 is obsolete| | Attachment #36481|0 |1 is obsolete| | Attachment #36482|0 |1 is obsolete| | Attachment #36483|0 |1 is obsolete| | Attachment #36484|0 |1 is obsolete| | Attachment #36485|0 |1 is obsolete| | Attachment #36486|0 |1 is obsolete| | Attachment #36487|0 |1 is obsolete| | Attachment #36488|0 |1 is obsolete| | Attachment #38509|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40395&action=edit Bug 10963: Simplified creation - BKS framework Patch 2/9 This patch rewrites BKS framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40397&action=edit Bug 10963: Simplified creation - SR framework Patch 4/9 This patch rewrites SR framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #75 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40399&action=edit Bug 10963: Simplified creation - AR framework Patch 6/9 This patch rewrites AR framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #77 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40401&action=edit Bug 10963: Simplified creation - IR framework Patch 8/9 This patch rewrites IR framework Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 --- Comment #79 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40403&action=edit Bug 10963: Revert old hidden values This patch reverts old hidden values to marc_subfield_structure. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #81 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Bernardo! -- You are receiving this mail because: You are watching all bug changes.