[Bug 19874] New: Move template JavaScript to the footer: UNIMARC editor plugins, part 5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Bug ID: 19874 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 Most UNIMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. This patch modifies yet more UNIMARC editor plugins. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70126&action=edit Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 This patch updates yet more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_125a.tt - unimarc_field_125b.tt - unimarc_field_126a.tt - unimarc_field_126b.tt - unimarc_field_127.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72863&action=edit Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 This patch updates yet more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_125a.tt - unimarc_field_125b.tt - unimarc_field_126a.tt - unimarc_field_126b.tt - unimarc_field_127.tt Signed-off-by: delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72863|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73252&action=edit Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 This patch updates yet more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_125a.tt - unimarc_field_125b.tt - unimarc_field_126a.tt - unimarc_field_126b.tt - unimarc_field_127.tt Signed-off-by: delaye <stephane.delaye@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877 [Bug 19877] Move template JavaScript to the footer: UNIMARC editor plugins, part 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Bug 19874 depends on bug 19872, which changed state. Bug 19872 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org