[Bug 28179] New: Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Bug ID: 28179 Summary: Use a lightbox gallery to display the images - detail page, staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 28178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 [Bug 28178] Image viewer does not select the correct image -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119914&action=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119915&action=edit Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface This patch adds the ability to display the cover images of a bibliographic record in a gallery. Cover images attached to items can also be displayed in separated galleries. Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on LocalCoverImages and AllowMultipleCovers b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on AmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on CustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119916&action=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Change sponsored?|--- |Unsponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This works really well overall, but there is a problem when there is a language toolbar in the footer. The toolbar completely obscures the footer for the gallery. I have some CSS update suggestions but I'm not sure what is the best way to modify the CSS... Change the original, since we're already using a modified version of the JS? Add a second CSS file to override? Use a copy of the original which we track separately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- The purpose of this change isn't clearly defined, but I think that I get the premise and it sounds interesting! I assume that this is a solution to the multiple cover problem? It would put the multiple book covers into a gallery that either manually or automatically scrolls on a per-row/biblio basis? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #4)
This works really well overall, but there is a problem when there is a language toolbar in the footer. The toolbar completely obscures the footer for the gallery.
I have some CSS update suggestions but I'm not sure what is the best way to modify the CSS... Change the original, since we're already using a modified version of the JS? Add a second CSS file to override? Use a copy of the original which we track separately?
Good catch, thanks! I would add it to the same file, at the bottom, with a comment saying it's some specific for us. What CSS suggestions do you have? (In reply to David Cook from comment #5)
The purpose of this change isn't clearly defined, but I think that I get the premise and it sounds interesting!
I assume that this is a solution to the multiple cover problem? It would put the multiple book covers into a gallery that either manually or automatically scrolls on a per-row/biblio basis?
Here the need is simply to display all the different cover images of a bibliographic record (or items) in a gallery. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)
Here the need is simply to display all the different cover images of a bibliographic record (or items) in a gallery.
Ah I see just on the detail page and not the search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120108&action=edit Bug 28179: (follow-up) Updates to styling of lightbox controls This patch fixes a bug and adds some style changes which I think are nice. The bugfix is to change the z-index of the lightbox footer so that it isn't hidden when there is a language menu in the footer. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. License information about Bootstrap Icons has been added to the About page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch is working great, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119914|0 |1 is obsolete| | Attachment #119915|0 |1 is obsolete| | Attachment #119916|0 |1 is obsolete| | Attachment #120108|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120253&action=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120254&action=edit Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface This patch adds the ability to display the cover images of a bibliographic record in a gallery. Cover images attached to items can also be displayed in separated galleries. Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on LocalCoverImages and AllowMultipleCovers b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on AmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on CustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120255&action=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120256&action=edit Bug 28179: (follow-up) Updates to styling of lightbox controls This patch fixes a bug and adds some style changes which I think are nice. The bugfix is to change the z-index of the lightbox footer so that it isn't hidden when there is a language menu in the footer. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. License information about Bootstrap Icons has been added to the About page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Unsponsored |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120253|0 |1 is obsolete| | Attachment #120254|0 |1 is obsolete| | Attachment #120255|0 |1 is obsolete| | Attachment #120256|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120409&action=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120410&action=edit Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface This patch adds the ability to display the cover images of a bibliographic record in a gallery. Cover images attached to items can also be displayed in separated galleries. Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on LocalCoverImages and AllowMultipleCovers b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on AmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on CustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120411&action=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120412&action=edit Bug 28179: (follow-up) Updates to styling of lightbox controls This patch fixes a bug and adds some style changes which I think are nice. The bugfix is to change the z-index of the lightbox footer so that it isn't hidden when there is a language menu in the footer. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. License information about Bootstrap Icons has been added to the About page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120413&action=edit Bug 28179: (follow-up) Remove console.log This patch removes a "console.log" from detail.tt and replaces it with similar output to the user. It will probably never be triggered, but better to handle it gracefully than have a hidden log. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120409|0 |1 is obsolete| | Attachment #120410|0 |1 is obsolete| | Attachment #120411|0 |1 is obsolete| | Attachment #120412|0 |1 is obsolete| | Attachment #120413|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120459&action=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120460&action=edit Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface This patch adds the ability to display the cover images of a bibliographic record in a gallery. Cover images attached to items can also be displayed in separated galleries. Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on LocalCoverImages and AllowMultipleCovers b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on AmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on CustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120461&action=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120462&action=edit Bug 28179: (follow-up) Updates to styling of lightbox controls This patch fixes a bug and adds some style changes which I think are nice. The bugfix is to change the z-index of the lightbox footer so that it isn't hidden when there is a language menu in the footer. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. License information about Bootstrap Icons has been added to the About page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120463&action=edit Bug 28179: (follow-up) Remove console.log This patch removes a "console.log" from detail.tt and replaces it with similar output to the user. It will probably never be triggered, but better to handle it gracefully than have a hidden log. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Signed-off-by patches attached on behalf of the sponsor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120459|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120731&action=edit Bug 28179: Add the Chocolat gallery lightbox JS library Chocolat is a lightbox JS library. https://chocolat.insipi.de https://github.com/nicolas-t/Chocolat https://chocolat.gitbook.io Why Chocolat? It's released under the GPL v3 license, easy to use, configure and extend, and is still maintained/active. (and it has a nice name) Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120460|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120732&action=edit Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface This patch adds the ability to display the cover images of a bibliographic record in a gallery. Cover images attached to items can also be displayed in separated galleries. Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on LocalCoverImages and AllowMultipleCovers b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on AmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on IntranetCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on CustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120461|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120733&action=edit Bug 28179: Adjust chocolat.js to display href In order to display link in the description we need to adjust chocolat.js Maybe this needs to be reported upstream Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120462|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120734&action=edit Bug 28179: (follow-up) Updates to styling of lightbox controls This patch fixes a bug and adds some style changes which I think are nice. The bugfix is to change the z-index of the lightbox footer so that it isn't hidden when there is a language menu in the footer. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. License information about Bootstrap Icons has been added to the About page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120463|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120735&action=edit Bug 28179: (follow-up) Remove console.log This patch removes a "console.log" from detail.tt and replaces it with similar output to the user. It will probably never be triggered, but better to handle it gracefully than have a hidden log. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Overall this works pretty great, but I am seeing something confusing in my testing: I've uploaded 2 local bib level covers. I've activated AdLibris covers. Looking at the detail page, I have 3 dots below the first cover and can swith back and forth, so far so good. When I click on the "second" dot, that is the second local cover and the one before the Adlibris one there is a "loading" icon that is not going away. I've tried changing the sequence of covers and services, it appears to remain showing on the "last" local cover one. And it's only on record level, not on the item level covers. ... And it remains without the patch set, so I am inclined to move this forward, but maybe worth looking at? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I have noticed that as well. Actually it's not a matter of position, but it depends on the size of the image. If the image is small you will see the loading image in the background. It's worth to open a new bug report. Thanks for the QA stamp! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- After discussion with Katrin and Owen I have decided to push this one for 21.05. It will help us to get feedbacks for the OPAC implementation (bug 28180) and eventually improve it for 21.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28314 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #31)
I have noticed that as well. Actually it's not a matter of position, but it depends on the size of the image. If the image is small you will see the loading image in the background. It's worth to open a new bug report.
Done: bug 28314 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Bug 28179 depends on bug 28178, which changed state. Bug 28178 Summary: Image viewer does not select the correct image https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds the release notes| |ability to display the | |cover images of a | |bibliographic record in a | |gallery. Cover images | |attached to items are also | |displayed in separated | |galleries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 [Bug 28825] Can't edit local cover image for item from details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307 [Bug 32307] Chocolat image viewer broken in the staff interface when Coce is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 [Bug 36966] Fix links for local cover images for items on staff detail page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org