[Bug 5819] New: No toolbar in record view when quotes present in title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 Bug #: 5819 Summary: No toolbar in record view when quotes present in title Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: januszop@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Created attachment 3235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3235 A screenshot illustrating the problem If there are double quotes in title (but also if there were any in lccn, isbn, issn, author, dewey, subject) the nice toolbar with buttons (cattoolbar) in normal view and MARC view (in staff client) will not appear. Instead there is a text list of options (cf. screenshot). The reason is that the JavaScript function GetZ3950Terms called when constructing the buttons fails, which is because of additional quotes in strQuery. The reason for this is that the C4::Search::z3950_search_args function does not escape quotes. A simple workaround will be submitted shortly. Regards, Janusz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 --- Comment #1 from januszop@gmail.com 2011-03-01 22:26:45 UTC --- Created attachment 3236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3236 Proposed patch This is a proposed workaround for the described problem. J. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 januszop@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |januszop@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 januszop@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 januszop@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3236|0 |1 is obsolete| | --- Comment #2 from januszop@gmail.com 2011-03-01 23:00:47 UTC --- Created attachment 3237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3237 Another patch Another possible fix inspired by Paul Poulain. J. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-14 06:22:21 UTC --- Patch work for me. Signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 08:02:27 UTC --- Pushed please test and mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5819 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org