[Bug 17988] New: Select2 prevents correct tag expand/ minimize functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Bug ID: 17988 Summary: Select2 prevents correct tag expand/minimize functionality Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: synapse.ova@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: — Thesaurus driven subfield → subfield with Select2 — Hidden subfield. Actual Results: — some fields become hidden, some not, and vice versa — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null» Expected Results: — all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Oleg Vasilenko <synapse.ova@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |synapse.ova@gmail.com --- Comment #1 from Oleg Vasilenko <synapse.ova@gmail.com> --- Created attachment 59543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59543&action=edit Bug 17988: add attribute check The following patch adds check for the needed attribute existance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Oleg Vasilenko <synapse.ova@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13501 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 [Bug 13501] Allow autocompletion on drop-down lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59543|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59758&action=edit [SIGNED-OFF] Bug 17988 - Select2 prevents correct tag expand/minimize functionality Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: — Thesaurus driven subfield → subfield with Select2 — Hidden subfield. Actual Results: — some fields become hidden, some not, and vice versa — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null» Expected Results: — all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. The following patch adds check for the needed attribute existance. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- I was able to reproduce the problem with field 942, with this patch it is OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59758|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59770&action=edit Bug 17988 - Select2 prevents correct tag expand/minimize functionality Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: — Thesaurus driven subfield → subfield with Select2 — Hidden subfield. Actual Results: — some fields become hidden, some not, and vice versa — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null» Expected Results: — all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. The following patch adds check for the needed attribute existance. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59771&action=edit Bug 17988: Add a comment to explain the line Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Oleg, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow up breaks the collapsing/uncollapsing of the fields - I think # is not allowed in Javascript for comments. Needs to be fixed on master - I will remove the second patch from my branch before pushing it up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #9 from Oleg Vasilenko <synapse.ova@gmail.com> --- It would be great, if another bug connected with Select2 would also be pushed to master — Bug 17780 It gives us a lot of problems, because authority records either are not added at all, or added without ID (and so would not be updated). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Oleg, we will need a sign-off there first - I have upped the severity a bit! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18119 [Bug 18119] Bug 17988 broke cataloging javascript functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Silly me, comment in JS is not #! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #7)
These patches have been pushed to 16.11.x and will be in 16.11.04.
Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Mason James from comment #12)
(In reply to Katrin Fischer from comment #7)
These patches have been pushed to 16.11.x and will be in 16.11.04.
Pushed to 16.05.x, for 16.05.10 release
Mason, you forgot bug 18119! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #14 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #13)
(In reply to Mason James from comment #12)
(In reply to Katrin Fischer from comment #7)
These patches have been pushed to 16.11.x and will be in 16.11.04.
Pushed to 16.05.x, for 16.05.10 release
Mason, you forgot bug 18119!
thanks!, i've pushed 18119 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org