[Bug 38114] New: columns_settings.inc used when not needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 Bug ID: 38114 Summary: columns_settings.inc used when not needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com columns_settings.inc is used from many templates, but sometimes it's not needed. KohaTable - columns_settings.inc kohaTable (DT REST API wrapper) - datatables.js If we do not use KohaTable we should not include columns_settings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33484 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- % grep -l 'columns_settings.inc' **/*.tt **/*.inc | xargs grep -L 'KohaTable' This could provide a first list, but it's not accurate. For instance: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt is a false positive (we use KohaTable from another js file) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- columns_settings.inc is going to be removed on bug 26553. *** This bug has been marked as a duplicate of bug 26553 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38114 Bug 38114 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org