[Bug 19708] New: Printing code improvements in opac-basket.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Bug ID: 19708 Summary: Printing code improvements in opac-basket.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: david.bourgault@inlibro.com Reporter: david.bourgault@inlibro.com QA Contact: testopia@bugs.koha-community.org The code for the printing function in opac-basket.tt contains a lot of useless branching. Additionally when printing a short basket (e.g.: 1 notice only), it will still print on two pages. To reproduce: 0) Add an item to your basket 1) Print basket: there will be an extra blank page after the basket. (This happens on Chrome and Firefox, I have not tested on other browsers) Patch will follow shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #1 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69417&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com | |, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 69432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69432&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 69433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69433&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69433|0 |1 is obsolete| | --- Comment #6 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 72613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72613&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by claude <claude.brayer@cea.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72640&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: claude <claude.brayer@cea.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72640|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73270&action=edit Bug 19708: Improve code for printing the cart in OPAC This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: claude <claude.brayer@cea.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, skipping for stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org