[Bug 5644] New: fines not cleared with dropbox mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Summary: fines not cleared with dropbox mode Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 It was my understanding that checking the dropbox mode option on the check in screen made the due date effectively the last day the library was open and as such wiped out fines for the extra day. It appears that is not the case. Fines for the item being late remain on the patron's account. The only way around this is to 'forgive fines' when using dropbox mode, but that forgives all fines and really we only want to forgive one day of fines. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-04-28 11:54:22 UTC --- Has anyone else noticed this issue? I'm hoping it's an easy fix. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-06-09 16:33:23 UTC --- Just a little nudge again :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Jesse Weaver <pianohacker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pianohacker@gmail.com --- Comment #3 from Jesse Weaver <pianohacker@gmail.com> 2011-07-07 01:23:41 UTC --- I can take a look at this, but my understanding is that a fines rewrite is in progress, right? Might be better to fix once we have a better foundation, unless this is extremely crucial and that's going to take a long time. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-07 01:34:10 UTC --- Speaking of that, there is stuff ready for initial testing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8087 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com Severity|major |critical --- Comment #5 from Melia Meggs <melia@bywatersolutions.com> --- This bug is kind of a big deal. Libraries need to be able to use dropbox mode to prevent the fine calculation from happening in the morning when they are checking in books that were put in the dropbox the night before. Right now in 3.8, they are not able to backdate the checkin date, so fines are being incorrectly charged on all books that come in from the dropbox. That's a lot of extra fines to remove manually every single day! Can we fix just the checkin date part of this without waiting on the entire Accountlines Rewrite? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm there are 2 different things here Melia. Backdating the checkin date, and wiping fines. Backdating the checkin date always used to work, and was working with this bug was logged. What wasn't working was that if the fines had already run things were not wiped. If you are saying now that you can't even backdate the checkin date that is a different problem and something broken recently. Is that the case? IF so, fixing the backdating will still not remove the fines, but if the books are checked in before the fines script runs they will not get fines added to them. So .. is setting the backdate broken now too? Or can you still do that and is the problem that you still don't wipe fines? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #7 from Melia Meggs <melia@bywatersolutions.com> --- Ah ok. Thanks for the explanation. I'm saying that backdating the checkin date is not working. (Maybe this needs a new bug report?) The library runs the fines script at noon. Before they upgraded to 3.8, they used to checkin the books from the dropbox in the morning and backdate the checkin date, so no fines were added for that day when the fines script ran at noon. Now they cannot backdate the checkin date, so fines get charged on those books. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Right that is a separate issue from the one nicole reported, which was an ehancement request to wipe fines already charged. Two choices, rename the description of this to be, dropbox mode doesnt set the correct date and leave it critical, and make a new one for the wiping fines, an ehancement, that is blocked by this. Or vice versa. I'm looking into the dropbox not setting the date issue now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|fines not cleared with |dropbox mode doesn't set |dropbox mode |the correct date -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8338 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #9 from Melia Meggs <melia@bywatersolutions.com> --- Thank you, Chris! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- The problem is in Koha::Calendar if ( $add_duration->is_negative() ){ $day_dur->inverse(); } This does not do what we expect, namely it does not invert the value. Working on a fix now -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10571&action=edit Bug 5644 : Fixing dropbox mode calculation -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- +----------------+------------+---------------------+------------+---------------+---------------------+-----------------+--------+----------+---------------------+---------------------+ | borrowernumber | itemnumber | date_due | branchcode | issuingbranch | returndate | lastreneweddate | return | renewals | timestamp | issuedate | +----------------+------------+---------------------+------------+---------------+---------------------+-----------------+--------+----------+---------------------+---------------------+ | 15861 | 23035 | 2012-07-21 23:59:00 | ME | NULL | 2012-06-29 09:10:00 | NULL | NULL | NULL | 2012-06-30 09:10:43 | 2012-06-30 09:09:00 | +----------------+------------+---------------------+------------+---------------+---------------------+-----------------+--------+----------+---------------------+---------------------+ Looks to be working now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #13 from Kyle M Hall <kyle.m.hall@gmail.com> --- Just looking at the diff, I'm wondering if this patch only fixes it if the library has only been closed for one day, and not for multiple days at a time. Nicole's description of her understanding of the feature is that "checking the dropbox mode option on the check in screen made the due date effectively the last day the library was open". What do you think? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, can't say anything about the code, but you described it right I think. That's how the feature has been documented and how I would expect it to work. So if people give something back over the weekend and I check it in Monday, the date should probably be Friday? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #15 from Nicole C. Engard <nengard@gmail.com> --- Yes, that's what should happen. Dropbox means that the patrons used the drop box for book/materials outside of the library. Many libraries don't penalize patrons who drop materials off while the library is closed so when the library opens again they take everything out of the box, and want to check the items in as if they were returned on a day the library was open. The intended side effect of this is that the patrons are not charged fines for the days the library was closed (if the library uses this feature). For libraries who don't have this policy they just don't use the drop box mode. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Albert Oller <ago@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tdavis@uttyler.edu --- Comment #16 from Albert Oller <ago@bywatersolutions.com> --- *** Bug 8087 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #13)
Just looking at the diff, I'm wondering if this patch only fixes it if the library has only been closed for one day, and not for multiple days at a time. Nicole's description of her understanding of the feature is that "checking the dropbox mode option on the check in screen made the due date effectively the last day the library was open". What do you think?
This is why just looking at a diff is an entirely ineffective way to test a patch. This bug now is to do with the dropbox not setting the correct date. Anything to do with fines is on another bug. So please talk about that issue there. Bug 8338 But if you look at the whole of the code, or better yet run it. You will see all the patch changes is setting the day_duration to be negative. It then, (depending on the mode the calendar is in, or if its hours does different things) EG my $days = abs $add_duration->in_units('days'); while ($days) { $base_date->add_duration($day_dur); if ( $self->is_holiday($base_date) ) { next; } else { --$days; } } If the library is closed, it will keep subtracting (in this case because $day_dur) is negative. This is how this had always worked, up until 3.8.0 and so that regression is now fixed. Please, looking at diffs is not really a valid test of anything. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10571|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10622&action=edit Bug 5644 : Fixing dropbox mode calculation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... I need a test plan, before pushing this patch:I tried -without the patch- to check-in a book, I checked "dropbox mode" I made a check-out of a book, return date july 31th Then I went to check-in, checked "Dropbox mode" button, made the checkin, and, in the database, I see: borrowernumber: 7852 itemnumber: 23170 date_due: 2012-07-31 23:59:00 branchcode: MAURES issuingbranch: NULL returndate: 2012-07-09 15:37:00 <<<<< YESTERDAY, dropbox mode OK lastreneweddate: NULL return: NULL renewals: NULL timestamp: 2012-07-10 15:37:45 issuedate: 2012-07-10 14:46:00 things seems OK. Any hint to understand what is fixed and I'll push it ! In the meantime = tiny patch, passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |paul.poulain@biblibre.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, I think the way to test this involves the holiday calendar. It should always use the last opening day as return date - so the question is probably if it does work correctly with single, weekly and repeated holidays between between the last opening day and the checkin day. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Yep, it depends on what calendar mode you have set, whether it works or not. The bug only manifests if you have days mode set to calendar (not date due). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #21)
Yep, it depends on what calendar mode you have set, whether it works or not.
The bug only manifests if you have days mode set to calendar (not date due).
Thanks, Testing = * set useDaysMode to "calendar" * reach return.pl page, click "dropbox mode, the display is "Dropbox Mode. (Effective checkin date is 14/07/2012 11:20 ).", which is wrong. * applying patch * reach return again, the display is "Dropbox Mode. (Effective checkin date is 11/07/2012 11:25 )." 12th is marked as closed => it's OK ! patch pushed ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- Failed test 'Negative call to addDate' # at t/Kalendar.t line 62. # '2011-06-15' # cmp # '2011-06-15' # Looks like you failed 1 test of 9. Weird thing happening here, that looks ok to me -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10622|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10835&action=edit Bug 5644 : Fixing the test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Fix for the test suite -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> --- Patch fixes the test, signed off & passed QA & push in one go -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed,will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org