[Bug 42442] New: Remove event attributes from bibliographic record merge template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Bug ID: 42442 Summary: Remove event attributes from bibliographic record merge template Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 38407 The template for merging bibliographic records has a couple of "onClick" event attributes which should be moved to the JS block in the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198018&action=edit Bug 42442: Remove event attributes from bibliographic record merge template This patch moves a couple of "onclick" event attributes from the bibliographic record merge template, moving the event handling to the JS block. This patch also makes a minor change to make sure that the framework code dropdown preselects the framework of the first of the records to merge. This brings it in line with the authority merge template. To test, apply the patch and perform a catalog search which will return multiple results including results with different frameworks. In the standard test data a search for "green" will return two results with two different frameworks. - Check the checkbox for at least two records in your search results. - Click "Edit -> Merge records" in the toolbar at the top of the results. - On the "Merging records" page you should see a frameowrk dropdown. It should have preselected the framework corresponding to the first of the records you selected. - When you click the radio buttons next to your records to merge the framework selection should change to match your selection.. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 198194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198194&action=edit Bug 42442: Remove event attributes from bibliographic record merge template This patch moves a couple of "onclick" event attributes from the bibliographic record merge template, moving the event handling to the JS block. This patch also makes a minor change to make sure that the framework code dropdown preselects the framework of the first of the records to merge. This brings it in line with the authority merge template. To test, apply the patch and perform a catalog search which will return multiple results including results with different frameworks. In the standard test data a search for "green" will return two results with two different frameworks. - Check the checkbox for at least two records in your search results. - Click "Edit -> Merge records" in the toolbar at the top of the results. - On the "Merging records" page you should see a frameowrk dropdown. It should have preselected the framework corresponding to the first of the records you selected. - When you click the radio buttons next to your records to merge the framework selection should change to match your selection.. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198602&action=edit Bug 42442: Remove event attributes from bibliographic record merge template This patch moves a couple of "onclick" event attributes from the bibliographic record merge template, moving the event handling to the JS block. This patch also makes a minor change to make sure that the framework code dropdown preselects the framework of the first of the records to merge. This brings it in line with the authority merge template. To test, apply the patch and perform a catalog search which will return multiple results including results with different frameworks. In the standard test data a search for "green" will return two results with two different frameworks. - Check the checkbox for at least two records in your search results. - Click "Edit -> Merge records" in the toolbar at the top of the results. - On the "Merging records" page you should see a frameowrk dropdown. It should have preselected the framework corresponding to the first of the records you selected. - When you click the radio buttons next to your records to merge the framework selection should change to match your selection.. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42442 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org