[Bug 16912] New: Koha:: Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Bug ID: 16912 Summary: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to ->extend_subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53342&action=edit Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53343&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53342|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53519&action=edit Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53343|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53520&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Sandre Cunha <cunha@monterey.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cunha@monterey.org --- Comment #5 from Sandre Cunha <cunha@monterey.org> --- I d't understand why this is under Acquisitions. Shouldn't it be under Patrons or circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Acquisitions |Architecture, internals, | |and plumbing --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it was a mistake - well spotted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia@hotmail.com --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #7)
fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t)
Apply cleanly on top of bug 16911. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #3)
Created attachment 53519 [details] [review] Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded
Tests failed: prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 1/8 Violation of unique constraint in Category at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201. Violation of unique constraint in Category at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201. Violation of unique constraint in Category at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201. # Failed test 'New kid pay 5' # at t/db_dependent/Koha/Patrons.t line 200. # got: '0' # expected: '5' # Failed test 'Kid growing and become a juvenile, but shouldn't pay for the upgrade ' # at t/db_dependent/Koha/Patrons.t line 206. # got: '0' # expected: '5' # Failed test 'Kid growing and become a juvenile, he should pay 15' # at t/db_dependent/Koha/Patrons.t line 215. # got: '0' # expected: '15' # Failed test 'Juvenile growing and become an young adult, he should pay 35' # at t/db_dependent/Koha/Patrons.t line 222. # got: '0' # expected: '35' # Looks like you failed 4 tests of 4. # Failed test 'add_enrolment_fee_if_needed' # at t/db_dependent/Koha/Patrons.t line 228. # Looks like you failed 1 test of 8. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 7 Non-zero exit status: 1 Files=1, Tests=8, 2 wallclock secs ( 0.03 usr 0.00 sys + 2.12 cusr 0.09 csys = 2.24 CPU) Result: FAIL The enrolment fee behaviour all works as expected, so happy to sign off once the tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53520|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54798&action=edit [SIGNED-OFF] Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54804&action=edit Bug 16912: Update patron category enrolment fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53519|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54836&action=edit [SIGNED-OFF] Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #13 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54837&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54804|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54838&action=edit [SIGNED-OFF] Bug 16912: Update patron category enrolment fees Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Sandre Cunha <cunha@monterey.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cunha@monterey.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #15 from Aleisha Amohia <aleishaamohia@hotmail.com> --- All tests pass and patch works as described, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- 16911 is in master: Applying: Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed fatal: sha1 information is lacking or useless (C4/Members.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54798|0 |1 is obsolete| | Attachment #54836|0 |1 is obsolete| | Attachment #54838|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56493&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56494&action=edit Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56495&action=edit Bug 16912: Update patron category enrolment fees Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56493|0 |1 is obsolete| | Attachment #56494|0 |1 is obsolete| | Attachment #56495|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56526&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56527&action=edit Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56528&action=edit Bug 16912: Update patron category enrolment fees Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks like this may need a rebase and a unit test fix up: t/db_dependent/Koha/Patrons.t .. 8/11 Violation of unique constraint in Category at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201. Violation of unique constraint in Category at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201. Violation of unique constraint in Category at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 201. # Failed test 'New kid pay 5' # at t/db_dependent/Koha/Patrons.t line 276. # got: '0' # expected: '5' # Failed test 'Kid growing and become a juvenile, but shouldn't pay for the upgrade ' # at t/db_dependent/Koha/Patrons.t line 282. # got: '0' # expected: '5' # Failed test 'Kid growing and become a juvenile, he should pay 15' # at t/db_dependent/Koha/Patrons.t line 291. # got: '0' # expected: '15' # Failed test 'Juvenile growing and become an young adult, he should pay 35' # at t/db_dependent/Koha/Patrons.t line 298. # got: '0' # expected: '35' # Looks like you failed 4 tests of 4. # Failed test 'add_enrolment_fee_if_needed' # at t/db_dependent/Koha/Patrons.t line 304. # Looks like you failed 1 test of 11. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 256 Tests: 11 Failed: 1) Failed test: 10 Non-zero exit status: 1 Files=1, Tests=11, 2 wallclock secs ( 0.04 usr 0.00 sys + 1.80 cusr 0.15 csys = 1.99 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56526|0 |1 is obsolete| | Attachment #56527|0 |1 is obsolete| | Attachment #56528|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56771&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56772&action=edit Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56773&action=edit Bug 16912: Update patron category enrolment fees Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #23)
Looks like this may need a rebase and a unit test fix up:
I got conflicts applying these patches and I cannot recreate the failures. Could you please retest with these patches again? I think I already got these failures with this test file. It looks like random failures caused by existing data and not directly linked with these changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 [Bug 21133] Missing use C4::Account statement in Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 13455 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org