[Bug 11939] New: Sample of currencies with a working active value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Bug ID: 11939 Summary: Sample of currencies with a working active value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org In default english setup currencies are in mysql/en/optional/parameters.sql file. The default is set to USA dollar because its value is '1' but now this setup is not enough. Now is better to add also values in 'active' column. I insert 'active' (value '1') for USA dollar, 'not active' (value '0') for others. The description in mysql/en/optional/parameters.txt file is no more correct, so I correct it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |z.tajoli@cineca.it |ity.org | --- Comment #1 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 26339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26339&action=edit better default for currencies, eng setup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26339|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26380&action=edit [SIGNED OFF] Bug 11939 - Better default for currencies This patch offers a better default for currencies, with USA dollar as default active currency. To test the patch: 1)Install master without the patch, during web installation select 'parameters.sql' file 2)Finish install and go to Administration -Currencies & Exchange rates 3)No active currency 4)Install master with this patch, during web installation select 'parameters.sql' file 5)Finish install and go to Administration -Currencies & Exchange rates 6)Now USA dollar is the active currency http://bugs.koha-community.org/show_bug.cgi?id=11939 NOTE: This does solve the problem of everything being NULL for active, and lacking an active value. It also corrects the description of the optional item to check related to currencies. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26415&action=edit Bug 11939: Add active currency for all data files Test plan: insert all sql files modified by this patch and verify the data is correctly inserted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Zeno, I completely agree but I think the change should be done for all languages data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #5 from Zeno Tajoli <z.tajoli@cineca.it> --- Ok, no problem. In your opipion canI check you patch ? Because I find difficult that someone wants to try six installation in 6 different languages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- mysql < /path/to/file.sql for each one should be enough. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- GAH! I think you were right to complain about the other currency files, Jonathan. However, did you not see how they differed? It would be nice if they were all standardized. All the currencies used in all the currency files should be in the currency files on every other language, though the default and active one should not be the same. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #7)
All the currencies used in all the currency files should be in the currency files on every other language, though the default and active one should not be the same.
Yes, it is what my patch does, if I understand you well. The only difference between 2 currency files would be the "active" value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- After discussing with Jonathan on IRC, we agreed to lock the scope of this to just adding the active column into the samples, and that another bug will deal with the clean up of the sample currency files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11954 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure that every file should have the same currencies. Depending on where you are you might order books from other countries - countries with the same language or neighbouring countries etc. I think it should be ok to leave some room for customizing those. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26439&action=edit Generates currency sql files to copy into place. What I was thinking about. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26415|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26440&action=edit [SIGNED OFF] Bug 11939: Add active currency for all data files Revised Test Plan ----------------- The following SQL commands were used to test this. installer/data/mysql/en/optional/parameters.sql is part of the first patch and didn't really need testing again. installer/data/mysql/de-DE/optional/parameters.sql is not part of the patch, but since I was playing with the script, which is also attached here, it was included for good measure. use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/pl-PL/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/es-ES/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/de-DE/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/en/optional/parameters.sql Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26380|0 |1 is obsolete| | Attachment #26440|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26523&action=edit [PASSED QA] Bug 11939 - Better default for currencies This patch offers a better default for currencies, with USA dollar as default active currency. To test the patch: 1)Install master without the patch, during web installation select 'parameters.sql' file 2)Finish install and go to Administration -Currencies & Exchange rates 3)No active currency 4)Install master with this patch, during web installation select 'parameters.sql' file 5)Finish install and go to Administration -Currencies & Exchange rates 6)Now USA dollar is the active currency http://bugs.koha-community.org/show_bug.cgi?id=11939 NOTE: This does solve the problem of everything being NULL for active, and lacking an active value. It also corrects the description of the optional item to check related to currencies. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26524&action=edit [PASSED QA] Bug 11939: Add active currency for all data files Revised Test Plan ----------------- The following SQL commands were used to test this. installer/data/mysql/en/optional/parameters.sql is part of the first patch and didn't really need testing again. installer/data/mysql/de-DE/optional/parameters.sql is not part of the patch, but since I was playing with the script, which is also attached here, it was included for good measure. use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/pl-PL/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/es-ES/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/de-DE/optional/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/en/optional/parameters.sql Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan and Zeno! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x, will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14179 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org