[Bug 10073] New: Show ccode or location also if not bound to Authorized Values in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 Bug ID: 10073 Summary: Show ccode or location also if not bound to Authorized Values in XSLT Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl If you do not have ccode or location governed by authorized value (you can release this default connection in the marc structure), these item values are not passed through in the items section, created by buildKohaItemsNamespace for XSLTParse4Display. This simple patch checks if the authorized value hash on ccode or location returns something and passes the original value in otherwise. Tested in connection with bug 9995, but can be seen separately. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17520&action=edit Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT If you do not have ccode or location governed by authorized value (you can release this default connection in the marc structure), these item values are not passed through in the items section, created by buildKohaItemsNamespace for XSLTParse4Display. This simple patch checks if the authorized value hash on ccode or location returns something and passes the original value in otherwise. Test plan: Temporarily disconnect ccode and location from authorized values in MARC structure. Edit an item, put some values in location and ccode. Look at this record via opac search (XSLT enabled). Toggle the value of OPACItemLocation to show ccode or location before call number. Restore authorized values-connection when applicable. Note: Since bug 9995 adjusts OPAC XSLT Results, it may be helpful to apply these patches when testing this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9995 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17520|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17539&action=edit Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT If you do not have ccode or location governed by authorized value (you can release this default connection in the marc structure), these item values are not passed through in the items section, created by buildKohaItemsNamespace for XSLTParse4Display. This simple patch checks if the authorized value hash on ccode or location returns something and passes the original value in otherwise. Test plan: Temporarily disconnect ccode and location from authorized values in MARC structure. Edit an item, put some values in location and ccode. Look at this record via opac search (XSLT enabled). Toggle the value of OPACItemLocation to show ccode or location before call number. Restore authorized values-connection when applicable. Note: Since bug 9995 adjusts OPAC XSLT Results, it may be helpful to apply these patches when testing this. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17603&action=edit [PASSED QA] Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT If you do not have ccode or location governed by authorized value (you can release this default connection in the marc structure), these item values are not passed through in the items section, created by buildKohaItemsNamespace for XSLTParse4Display. This simple patch checks if the authorized value hash on ccode or location returns something and passes the original value in otherwise. Test plan: Temporarily disconnect ccode and location from authorized values in MARC structure. Edit an item, put some values in location and ccode. Look at this record via opac search (XSLT enabled). Toggle the value of OPACItemLocation to show ccode or location before call number. Restore authorized values-connection when applicable. Note: Since bug 9995 adjusts OPAC XSLT Results, it may be helpful to apply these patches when testing this. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described for the XSLT result list. The text is shown when OpacItemLocation is set to show collection or location. Note: Displaying location and collection without using authorised values doesn't work in other places like the detail page item table. So this will need more work to be fully functional. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10073 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org